add LongHashSet todo

apache · Feb 4, 2023 · db2de86 · db2de86
1 parent 86fdcc2
commit db2de86
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java b/lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java
@@ -647,6 +647,8 @@ private Scorer docValuesScorer(LeafReader reader) throws IOException {
         SortedSetDocValues dv = DocValues.getSortedSet(reader, field);
 
         boolean hasAtLeastOneTerm = false;
+        // TODO: Consider LongHashSet instead. Benchmarks hinted that this might increase latency
+        // by as much as 20%, but we should revisit.
         LongBitSet ords = new LongBitSet(dv.getValueCount());
         PrefixCodedTerms.TermIterator termIterator = termData.iterator();
         for (BytesRef term = termIterator.next(); term != null; term = termIterator.next()) {