Don't generate stacktrace in CollectionTerminatedException (#12270)

CollectionTerminatedException is always caught and never exposed to users so there's no point in filling in a stack-trace for it.
apache · May 9, 2023 · ae305f8 · ae305f8
1 parent 15568ca
commit ae305f8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
@@ -19,7 +19,8 @@ Improvements
 
 Optimizations
 ---------------------
-(No changes)
+
+* GITHUB#12270 Don't generate stacktrace in CollectionTerminatedException. (Armin Braun)
 
 Bug Fixes
 ---------------------

diff --git a/lucene/core/src/java/org/apache/lucene/search/CollectionTerminatedException.java b/lucene/core/src/java/org/apache/lucene/search/CollectionTerminatedException.java
@@ -31,4 +31,10 @@ public final class CollectionTerminatedException extends RuntimeException {
   public CollectionTerminatedException() {
     super();
   }
+
+  @Override
+  public Throwable fillInStackTrace() {
+    // never re-thrown so we can save the expensive stacktrace
+    return this;
+  }
 }