Remove deprecated float vector classes and methods (#12107)

Follow-up of #12105 to remove the deprecated classes for the next major version.

Removes KnnVectorField, KnnVectorQuery, VectorValues and LeafReader#getVectorValues.

lucene/CHANGES.txt

@@ -44,6 +44,9 @@ API Changes
 
 * GITHUB#11814: Support deletions in IndexRearranger. (Stefan Vodita)
 
+* GITHUB#12107: Remove deprecated KnnVectorField, KnnVectorQuery, VectorValues and
+  LeafReader#getVectorValues. (Luca Cavanna)
+
 New Features
 ---------------------
 

lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswGraphBuilder.java

@@ -60,7 +60,7 @@ public final class Lucene90HnswGraphBuilder {
   private final RandomAccessVectorValues<float[]> buildVectors;
 
   /**
-   * Reads all the vectors from a VectorValues, builds a graph connecting them by their dense
+   * Reads all the vectors from vector values, builds a graph connecting them by their dense
    * ordinals, using the given hyperparameter settings, and returns the resulting graph.
    *
    * @param vectors the vectors whose relations are represented by the graph - must provide a
@@ -96,8 +96,8 @@ public Lucene90HnswGraphBuilder(
   }
 
   /**
-   * Reads all the vectors from two copies of a random access VectorValues. Providing two copies
-   * enables efficient retrieval without extra data copying, while avoiding collision of the
+   * Reads all the vectors from two copies of a {@link RandomAccessVectorValues}. Providing two
+   * copies enables efficient retrieval without extra data copying, while avoiding collision of the
    * returned values.
    *
    * @param vectors the vectors for which to build a nearest neighbors graph. Must be an independet

lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene91/Lucene91HnswGraphBuilder.java

@@ -67,7 +67,7 @@ public final class Lucene91HnswGraphBuilder {
   private RandomAccessVectorValues<float[]> buildVectors;
 
   /**
-   * Reads all the vectors from a VectorValues, builds a graph connecting them by their dense
+   * Reads all the vectors from vector values, builds a graph connecting them by their dense
    * ordinals, using the given hyperparameter settings, and returns the resulting graph.
    *
    * @param vectors the vectors whose relations are represented by the graph - must provide a
@@ -112,8 +112,8 @@ public Lucene91HnswGraphBuilder(
   }
 
   /**
-   * Reads all the vectors from two copies of a random access VectorValues. Providing two copies
-   * enables efficient retrieval without extra data copying, while avoiding collision of the
+   * Reads all the vectors from two copies of a {@link RandomAccessVectorValues}. Providing two
+   * copies enables efficient retrieval without extra data copying, while avoiding collision of the
    * returned values.
    *
    * @param vectors the vectors for which to build a nearest neighbors graph. Must be an independet

lucene/core/src/java/org/apache/lucene/codecs/BufferingKnnVectorsWriter.java

@@ -105,7 +105,7 @@ public TopDocs search(
     }
   }
 
-  /** Sorting VectorValues that iterate over documents in the order of the provided sortMap */
+  /** Sorting FloatVectorValues that iterate over documents in the order of the provided sortMap */
   private static class SortingVectorValues extends FloatVectorValues {
     private final BufferedVectorValues randomAccess;
     private final int[] docIdOffsets;

lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsFormat.java

@@ -84,7 +84,7 @@ public static KnnVectorsFormat forName(String name) {
       new KnnVectorsFormat("EMPTY") {
         @Override
         public KnnVectorsWriter fieldsWriter(SegmentWriteState state) {
-          throw new UnsupportedOperationException("Attempt to write EMPTY VectorValues");
+          throw new UnsupportedOperationException("Attempt to write EMPTY vector values");
         }
 
         @Override

lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java

@@ -138,7 +138,7 @@ public int nextDoc() throws IOException {
     }
   }
 
-  /** View over multiple VectorValues supporting iterator-style access via DocIdMerger. */
+  /** View over multiple vector values supporting iterator-style access via DocIdMerger. */
   protected static final class MergedVectorValues {
     private MergedVectorValues() {}
 

lucene/core/src/java/org/apache/lucene/document/FieldType.java

@@ -380,7 +380,7 @@ public void setVectorAttributes(
     }
     if (numDimensions > FloatVectorValues.MAX_DIMENSIONS) {
       throw new IllegalArgumentException(
-          "vector numDimensions must be <= VectorValues.MAX_DIMENSIONS (="
+          "vector numDimensions must be <= FloatVectorValues.MAX_DIMENSIONS (="
               + FloatVectorValues.MAX_DIMENSIONS
               + "); got "
               + numDimensions);

lucene/core/src/java/org/apache/lucene/document/KnnFloatVectorField.java

@@ -30,9 +30,9 @@
  * an array (of type float[]) whose length is the vector dimension. Values can be retrieved using
  * {@link FloatVectorValues}, which is a forward-only docID-based iterator and also offers
  * random-access by dense ordinal (not docId). {@link VectorSimilarityFunction} may be used to
- * compare vectors at query time (for example as part of result ranking). A KnnVectorField may be
- * associated with a search similarity function defining the metric used for nearest-neighbor search
- * among vectors of that field.
+ * compare vectors at query time (for example as part of result ranking). A {@link
+ * KnnFloatVectorField} may be associated with a search similarity function defining the metric used
+ * for nearest-neighbor search among vectors of that field.
  *
  * @lucene.experimental
  */

lucene/core/src/java/org/apache/lucene/index/CheckIndex.java

@@ -377,7 +377,7 @@ public static final class PointsStatus {
       public Throwable error;
     }
 
-    /** Status from testing VectorValues */
+    /** Status from testing vector values */
     public static final class VectorValuesStatus {
 
       VectorValuesStatus() {}
@@ -1015,7 +1015,7 @@ private Status.SegmentInfoStatus testSegment(
         // Test PointValues
         segInfoStat.pointsStatus = testPoints(reader, infoStream, failFast);
 
-        // Test VectorValues
+        // Test FloatVectorValues and ByteVectorValues
         segInfoStat.vectorValuesStatus = testVectors(reader, infoStream, failFast);
 
         // Test Index Sort

lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java

@@ -454,11 +454,11 @@ private void checkAndThrow() {
           throw new ExitingReaderException(
               "The request took too long to iterate over vector values. Timeout: "
                   + queryTimeout.toString()
-                  + ", VectorValues="
+                  + ", FloatVectorValues="
                   + in);
         } else if (Thread.interrupted()) {
           throw new ExitingReaderException(
-              "Interrupted while iterating over vector values. VectorValues=" + in);
+              "Interrupted while iterating over vector values. FloatVectorValues=" + in);
         }
       }
     }
@@ -521,11 +521,11 @@ private void checkAndThrow() {
           throw new ExitingReaderException(
               "The request took too long to iterate over vector values. Timeout: "
                   + queryTimeout.toString()
-                  + ", VectorValues="
+                  + ", ByteVectorValues="
                   + in);
         } else if (Thread.interrupted()) {
           throw new ExitingReaderException(
-              "Interrupted while iterating over vector values. VectorValues=" + in);
+              "Interrupted while iterating over vector values. ByteVectorValues=" + in);
         }
       }
     }

lucene/core/src/java/org/apache/lucene/index/FieldInfos.java

@@ -244,7 +244,7 @@ public boolean hasPointValues() {
     return hasPointValues;
   }
 
-  /** Returns true if any fields have VectorValues */
+  /** Returns true if any fields have vector values */
   public boolean hasVectorValues() {
     return hasVectorValues;
   }

lucene/core/src/java/org/apache/lucene/index/LeafReader.java

@@ -199,17 +199,6 @@ public final PostingsEnum postings(Term term) throws IOException {
    */
   public abstract NumericDocValues getNormValues(String field) throws IOException;
 
-  /**
-   * Returns {@link VectorValues} for this field, or null if no {@link VectorValues} were indexed.
-   * The returned instance should only be used by a single thread.
-   *
-   * @deprecated use {@link #getFloatVectorValues(String)} instead
-   */
-  @Deprecated
-  public VectorValues getVectorValues(String field) throws IOException {
-    return new FilterVectorValues(getFloatVectorValues(field)) {};
-  }
-
   /**
    * Returns {@link FloatVectorValues} for this field, or null if no {@link FloatVectorValues} were
    * indexed. The returned instance should only be used by a single thread.

lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java

@@ -212,7 +212,7 @@ public PointValues.Relation compare(byte[] minPackedValue, byte[] maxPackedValue
     }
   }
 
-  /** Sorting VectorValues that iterate over documents in the order of the provided sortMap */
+  /** Sorting FloatVectorValues that iterate over documents in the order of the provided sortMap */
   private static class SortingFloatVectorValues extends FloatVectorValues {
     final int size;
     final int dimension;

lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java

@@ -239,7 +239,7 @@ public int hashCode() {
   }
 
   /**
-   * @return the KnnVectorField where the KnnVector search happens.
+   * @return the knn vector field where the knn vector search happens.
    */
   public String getField() {
     return field;