-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add randomized matrix for better test coverage #693
Conversation
40037be
to
bcdbacb
Compare
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
=========================================
Coverage 55.59% 55.59%
Complexity 10336 10336
=========================================
Files 1059 1059
Lines 65045 65045
Branches 7399 7399
=========================================
+ Hits 36160 36161 +1
Misses 26336 26336
+ Partials 2549 2548 -1
Continue to review full report at Codecov.
|
b299a2f
to
c8db52a
Compare
c8db52a
to
f97d21a
Compare
f97d21a
to
31d5940
Compare
1bca384
to
8068fac
Compare
8068fac
to
bed24df
Compare
Use IdentityHashMap instead of HashMap when key is TestElement See apache#693
28ebcb6
to
4157d37
Compare
Use IdentityHashMap instead of HashMap when key is TestElement See apache#693
5ce41d5
to
5e4ed16
Compare
Use IdentityHashMap instead of HashMap when key is TestElement See apache#693
5e4ed16
to
1ce3bb4
Compare
Use IdentityHashMap instead of HashMap when key is TestElement See apache#693
1ce3bb4
to
e9b867e
Compare
Use IdentityHashMap instead of HashMap when key is TestElement See apache#693
e9b867e
to
db8984f
Compare
Use IdentityHashMap instead of HashMap when key is TestElement See apache#693
7125112
to
d5eb569
Compare
Use IdentityHashMap instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
45149a4
to
5f07a00
Compare
I'm going to merge this PR shortly unless there are objections. It looks like external users have much fewer usages for Unfortunately, the PR adds new usages of |
…Map instead of HashMap when key is TestElement See apache#693
__changeCase uses java-default locale, so the test does not support tr_TR locale. See apache#5723
…Map instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
…Map instead of HashMap when key is TestElement See apache#693
See https://github.com/vlsi/github-actions-random-matrix
Motivation and Context
This enables testing with different Java distributions, Java versions, Locales, Time Zones, etc.
Open issues so far:
Spock does not work in tr_TR locale: Unrecognized block label: given @ line 31, column 13. spockframework/spock#1414 (reproducer PR ci: add randomized test matrix for better test coverage spockframework/spock#1415)
Support ParallelExecutionConfigurationStrategy with Turkish locale junit-team/junit5#2890
Avoid relying on item.hashCode() for Map and Collection properties #5923
CSVDataSet might produce wrong results in SHARE_GROUP or SHARE_THREAD modes as it relies on System.identityHashCode uniqueness for ThreadGroup and Thread #5925
same hashcode
jobs fail with. Fixed by movingHashTree
toIdentityHashMap
and movingMap<TestElement, ..
toIdentityHashMap
as wellJava 8 + same hashcode fails at
:src:dist:processSiteXslt
withVerifyError
. I'm inclined to skipprocessSiteXslt
when building with Java8 and same hashcode. We might retry if the bug is solved when xalan is updated.