Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running on java-ea for travis builds. #438

Closed
wants to merge 6 commits into from
Closed

Try running on java-ea for travis builds. #438

wants to merge 6 commits into from

Conversation

FSchumacher
Copy link
Contributor

Description

Enable builds for Java EA on travis ci

Motivation and Context

We should get early warnings, when JMeter doesn't run on EA versions of Java.

How Has This Been Tested?

Will get tested by travis :)

Screenshots (if appropriate):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@pmouawad
Copy link
Contributor

pmouawad commented Feb 3, 2019

+1

@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #438 into trunk will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk     #438   +/-   ##
=========================================
  Coverage     58.57%   58.57%           
+ Complexity    10776    10775    -1     
=========================================
  Files          1206     1206           
  Lines         77193    77193           
  Branches       7456     7456           
=========================================
  Hits          45213    45213           
+ Misses        29452    29451    -1     
- Partials       2528     2529    +1
Impacted Files Coverage Δ Complexity Δ
...s/org/apache/jmeter/timers/PoissonRandomTimer.java 72.97% <0%> (-5.41%) 9% <0%> (-1%)
...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java 56.98% <0%> (+2.15%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ec77f...02829d2. Read the comment docs.

@pmouawad
Copy link
Contributor

pmouawad commented Feb 3, 2019

Hi Felix,
Since you're working on this.
I see that when when we use openjdk11, we have those warnings:

warning: [options] bootstrap class path not set in conjunction with -source 8

Shouldn't we set source and target to 11 ?
Regards

@FSchumacher
Copy link
Contributor Author

Hi Felix,
Since you're working on this.
I see that when when we use openjdk11, we have those warnings:

warning: [options] bootstrap class path not set in conjunction with -source 8

Shouldn't we set source and target to 11 ?
Regards

Well, as long as we are on Java 8 as minimum version, we should compile with something, that is compatible. That probably means:

But for this PR I am happy to have included the EA builds (even if they are failing right now)

@asfgit asfgit closed this in 295528a Feb 3, 2019
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants