Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAMES-4072 Add SSL configuration for redis cluster topology #2669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arsnael
Copy link
Contributor

@Arsnael Arsnael commented Mar 7, 2025

No description provided.

@hungphan227
Copy link
Contributor

May need a test

@Arsnael
Copy link
Contributor Author

Arsnael commented Mar 7, 2025

May need a test

No, cf other draft PR on the refactoring. We concluded with @chibenwa that adding tests on all redis topologies was not really necessary and was just adding monstrous unnecessary complexity to the test suite. So just keeping one test for it (redis standalone) should be enough, we can accept for the rest

@hungphan227
Copy link
Contributor

May need a test

No, cf other draft PR on the refactoring. We concluded with @chibenwa that adding tests on all redis topologies was not really necessary and was just adding monstrous unnecessary complexity to the test suite. So just keeping one test for it (redis standalone) should be enough, we can accept for the rest

I think at least do manual test to make sure. Ssl for different topology may require different redis client code and setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants