Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment Apache Kvrocks to back our tests #2660

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quantranhong1999
Copy link
Member

Experiment with Apache Kvrocks (as a Redis drop-in replacement) to see if it plays well with our test suite.

First step: standalone Kvrocks seems to play well with tests on my local.

We need to check Sentinel mode and likely Cluster mode also.

@chibenwa
Copy link
Contributor

Maybe we could raise the topic on the mailing list?

@chibenwa
Copy link
Contributor

chibenwa commented Mar 4, 2025

<3 🟢 build

@Arsnael
Copy link
Contributor

Arsnael commented Mar 4, 2025

Shall we adapt this to have kvrocks tests alongside redis in the code base?

@chibenwa
Copy link
Contributor

chibenwa commented Mar 4, 2025

Shall we adapt this to have kvrocks tests alongside redis in the code base?

+1 for having the tests

However I'm not sure we need to run 100% of them. Smoke tests maybe?
Or even with a specific profile?
Or even disabled so that DEVs can run it if need be...
Or if LINAGORA is interested in those tests (I think we do) it is something LINAGORA can run as part of Twake Mail build?


Maybe we can move along by:

  • Having a sample test, disabled for now.
  • Running those tests in Twake Mail (in a new integration-tests/kvrocks module)
  • AND launching a discussion / vote on the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants