Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-11377: Remove usage of Guava ByteStreams.toByteArray() #1971

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

reschke
Copy link
Contributor

@reschke reschke commented Jan 10, 2025

No description provided.

@reschke reschke self-assigned this Jan 10, 2025
@reschke reschke marked this pull request as draft January 10, 2025 06:33
Copy link

github-actions bot commented Jan 10, 2025

Commit-Check ❌

Commit rejected by Commit-Check.                                  
                                                                  
  (c).-.(c)    (c).-.(c)    (c).-.(c)    (c).-.(c)    (c).-.(c)  
   / ._. \      / ._. \      / ._. \      / ._. \      / ._. \   
 __\( C )/__  __\( H )/__  __\( E )/__  __\( C )/__  __\( K )/__ 
(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)
   || E ||      || R ||      || R ||      || O ||      || R ||   
 _.' '-' '._  _.' '-' '._  _.' '-' '._  _.' '-' '._  _.' '-' '._ 
(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)
 `-´     `-´  `-´     `-´  `-´     `-´  `-´     `-´  `-´     `-´ 
                                                                  
Commit rejected.                                                  
                                                                  
Type message check failed => Revert "OAK-11377: Remove usage of Guava ByteStreams.toByteArray() - avoid deprecated method"

This reverts commit d210344be29f8b855270e338fd08f64a60ce102f.

(as this change is beyond the scope of this PR)
 
It doesn't match regex: ^OAK-\d+:?\s\S+.*
The commit message must start with 'OAK-<ID>[:] ' followed by some descriptive text
Suggest: Please check your commit message whether it matches above regex

@reschke reschke marked this pull request as ready for review January 10, 2025 09:18
…avoid deprecated method"

This reverts commit d210344.

(as this change is beyond the scope of this PR)
@reschke reschke merged commit 9111252 into trunk Jan 10, 2025
1 of 3 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants