OAK-11360: remove usage of Guava Ints.contains() #1958
Conversation
Commit-Check ✔️ |
| } | ||
|
|
||
| public static boolean canCreateTypedField(Type<?> type) { | ||
| return Ints.contains(TYPABLE_TAGS, type.tag()); | ||
| return TYPABLE_TAGS.contains(type.tag()); |
There was a problem hiding this comment.
| return TYPABLE_TAGS.contains(type.tag()); | |
| return Arrays.stream(TYPABLE_TAGS).anyMatch(tag -> tag == type.tag()); |
and we keep the type of TYPABLE_TAGS as int[].
There was a problem hiding this comment.
Or we could change TYPABLE_TAGS to Set and take advantage of Set.contains API.
@reschke wdyt ?
There was a problem hiding this comment.
I wanted to avoid to convert ints to Integers every time we do the check.
I also assumed that the original author believed that sorting the array/list would help improve performance.
If this is not the case we of course could make it a Set.
There was a problem hiding this comment.
AFAIK List.contains always run in linear time irrespective of whether List is sorted or not.
There was a problem hiding this comment.
Yes, sorting only helps if the lower values need to be looked up more frequently.
We could check the code what is really needed here. Or we can just keep things the way they are :-)
|
No description provided.