【remember to add Hu and Peng to co-arthor and delete this bracket before merge】IoTConsensus and IoTConsensusV2 no longer stores the peer list locally on the DataNode #14814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pengzna
reviewed
Feb 13, 2025
| @@ -174,7 +175,7 @@ private void initAndRecover() throws IOException { | |||
| new IoTConsensusServerImpl( | |||
| path.toString(), | |||
| new Peer(consensusGroupId, thisNodeId, thisNode), | |||
| new ArrayList<>(), | |||
| new TreeSet<>(), | |||
There was a problem hiding this comment.
Previously, duplicates were removed during configuration persistence. Now that the persistence code is gone, a set is used to keep this logic.
TreeSet is used to return a List with a consistent order (for an interface), which I believe is better than the unordered HashSet.
...core/consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/LogDispatcher.java
Outdated
Show resolved
Hide resolved
OneSizeFitsQuorum
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
resetPeerListinterface is super powerful.Now, IoTConsensus member management can be fully handled by ConfigNode, and DataNode can simply obtain the peer list from ConfigNode during startup (through
resetPeerListinterface).