Implemented JDBC for IoTDB based on tables #14656
Open
+3,813
−3,211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTHou
reviewed
Jan 9, 2025
sync remote and local code
jdbc activeByDefault get-jar-with-dependencies
CritasWang
requested changes
Feb 5, 2025
iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java
Outdated
Show resolved
Hide resolved
iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java
Show resolved
Hide resolved
iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBAbstractDatabaseMetadata.java
Outdated
Show resolved
Hide resolved
JackieTien97
requested changes
Feb 6, 2025
Comment on lines
52
to
53
| public static final Logger logger = org.slf4j.LoggerFactory.getLogger(IoTDBStatement.class); | ||
|
|
There was a problem hiding this comment.
what's this used for? You should define the logger for each class
Comment on lines
72
to
77
| LOGGER.info( | ||
| "GetTables:: catalog:{}, schemaPattern:{}, tableNamePattern:{}, types:{}", | ||
| catalog, | ||
| schemaPattern, | ||
| tableNamePattern, | ||
| types); |
There was a problem hiding this comment.
Suggested change
| LOGGER.info( | |
| "GetTables:: catalog:{}, schemaPattern:{}, tableNamePattern:{}, types:{}", | |
| catalog, | |
| schemaPattern, | |
| tableNamePattern, | |
| types); |
|
|
||
| @Override | ||
| public ResultSet getTables( | ||
| String catalog, String schemaPattern, String tableNamePattern, String[] types) |
There was a problem hiding this comment.
schemaPattern and tableNamePattern are botn pattern, you should use like to do that filter. And the interface definition also tells the order of the result, you should order by database, table_name.
you can use information_schema.tables to do that. https://timechor.feishu.cn/docx/Mqi9dCcu2oXLo4xxZVbcn8SKnKh
|
|
||
| @Override | ||
| public ResultSet getColumns( | ||
| String catalog, String schemaPattern, String tableNamePattern, String columnNamePattern) |
There was a problem hiding this comment.
use information_schema.columns to do that.
Comment on lines
159
to
164
| LOGGER.info( | ||
| "GetColumns:: catalog:{}, schemaPattern:{}, tableNamePattern:{}, columnNamePattern:{}", | ||
| catalog, | ||
| schemaPattern, | ||
| tableNamePattern, | ||
| columnNamePattern); |
There was a problem hiding this comment.
Suggested change
| LOGGER.info( | |
| "GetColumns:: catalog:{}, schemaPattern:{}, tableNamePattern:{}, columnNamePattern:{}", | |
| catalog, | |
| schemaPattern, | |
| tableNamePattern, | |
| columnNamePattern); |
| } | ||
|
|
||
| static { | ||
| String[] allIotdbSQLKeywords = { |
There was a problem hiding this comment.
keywords of table and tree model are different, you can find keywords of table model in https://timechor.feishu.cn/docx/U5OHdYQs1oR0hVxvy5Ucw0KUnBf
Comment on lines
849
to
873
| ResultSet resultSet = null; | ||
| Statement statement = null; | ||
| String result = ""; | ||
| try { | ||
| statement = connection.createStatement(); | ||
| StringBuilder str = new StringBuilder(""); | ||
| resultSet = statement.executeQuery(SHOW_FUNCTIONS); | ||
| List<String> listFunction = Arrays.asList("MAX_TIME", "MIN_TIME", "TIME_DIFFERENCE", "NOW"); | ||
| while (resultSet.next()) { | ||
| if (listFunction.contains(resultSet.getString(1))) { | ||
| continue; | ||
| } | ||
| str.append(resultSet.getString(1)).append(","); | ||
| } | ||
| result = str.toString(); | ||
| if (!result.isEmpty()) { | ||
| result = result.substring(0, result.length() - 1); | ||
| } | ||
| } catch (Exception e) { | ||
| LOGGER.error("Get numeric functions error: {}", e.getMessage()); | ||
| } finally { | ||
| close(resultSet, statement); | ||
| } | ||
| return result; | ||
| } |
CritasWang
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Changes
Key Results