Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip insertion compaction disk space check #11959

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Skip insertion compaction disk space check #11959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...b/storageengine/dataregion/compaction/execute/task/InsertionCrossSpaceCompactionTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,11 @@ public boolean equalsOtherTask(AbstractCompactionTask otherTask) {
return false;
}

@Override
public boolean isDiskSpaceCheckPassed() {
return true;
}

@Override
public long getEstimatedMemoryCost() {
return 0;
Expand Down
25 changes: 25 additions & 0 deletions ...rageengine/dataregion/compaction/selector/utils/InsertionCrossCompactionTaskResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@

import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;

import java.util.ArrayList;
import java.util.List;

public class InsertionCrossCompactionTaskResource extends CrossCompactionTaskResource {
public TsFileResource prevSeqFile = null;
public TsFileResource nextSeqFile = null;
Expand All @@ -37,6 +40,28 @@ public float getTotalSeqFileSize() {
return super.getTotalSeqFileSize();
}

@Override
public List<TsFileResource> getSeqFiles() {
List<TsFileResource> seqFiles = new ArrayList<>(2);
if (prevSeqFile != null) {
seqFiles.add(prevSeqFile);
}
if (nextSeqFile != null) {
seqFiles.add(nextSeqFile);
}
return seqFiles;
}

@Override
public List<TsFileResource> getUnseqFiles() {
List<TsFileResource> unseqFiles = new ArrayList<>(2);
unseqFiles.add(firstUnSeqFileInParitition);
if (toInsertUnSeqFile != firstUnSeqFileInParitition) {
unseqFiles.add(toInsertUnSeqFile);
}
return unseqFiles;
}

@Override
public boolean isValid() {
return toInsertUnSeqFile != null;
Expand Down