Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-9969][Agent] Release the memory semaphore of the source only when the data is placed in the queue #9971

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[INLONG-9969][Agent] Release the memory semaphore of the source only when the data is placed in the queue #9971

merged 1 commit into from
Apr 11, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Apr 10, 2024 •
edited
Loading

[INLONG-9969][Agent] Release the memory semaphore of the source only when the data is placed in the queue

Motivation

Due to the immediate release of semaphores after data is read from the data source, memory control cannot be achieved.

Modifications

Release the memory semaphore of the source only when the data is placed in the queue

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

no doc need

@justinwwhuang justinwwhuang added this to the 1.12.0 milestone Apr 10, 2024
@justinwwhuang justinwwhuang self-assigned this Apr 10, 2024
@dockerzhang dockerzhang merged commit 24bdfc1 into apache:master Apr 11, 2024
11 checks passed
@justinwwhuang justinwwhuang deleted the b9969 branch April 11, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@aloyszhang aloyszhang aloyszhang approved these changes

@luchunliang luchunliang Awaiting requested review from luchunliang

@haifxu haifxu Awaiting requested review from haifxu

Assignees

@justinwwhuang justinwwhuang

Labels
component/agent
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Release the memory semaphore of the source only when the data is placed in the queue
4 participants
@justinwwhuang @dockerzhang @aloyszhang @haifxu