Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-9760][Manager] make sure BufferedReader close properly #9761

Merged
merged 2 commits into from
Mar 1, 2024
Merged

[INLONG-9760][Manager] make sure BufferedReader close properly #9761

merged 2 commits into from
Mar 1, 2024

Conversation

aloyszhang
Copy link
Contributor

Motivation

make sure BufferedReader closes properly after use

Modifications

Unify the use of BufferedReader by try-with-resource block

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

Documentation

no docs needed

vernedeng
vernedeng approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@vernedeng vernedeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit 408baab into apache:master Mar 1, 2024
8 checks passed
@aloyszhang aloyszhang deleted the resource branch June 5, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@vernedeng vernedeng vernedeng approved these changes

@fuweng11 fuweng11 fuweng11 approved these changes

Assignees
No one assigned
Labels
component/manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][Manager] resource may leak due to BufferedReader not closed
4 participants
@aloyszhang @dockerzhang @vernedeng @fuweng11