Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9333][Sort] Related problem with attribute exceptions when creating 'hudiSink' #9334

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

LiJie20190102
Copy link
Contributor

Related problem with attribute exceptions when creating 'hudiSink'

Prepare a Pull Request

(Change the title refer to the following example)

  • [INLONG-9333][Sort] Related problem with attribute exceptions when creating 'hudiSink'

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

When I tried to create a 'hudiSink', some properties did not prompt me to enter, but an error occurred

Modifications

If some parameters are necessary, the task creation will prompt that these parameters must be assigned values

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • [ √] This change is already covered by existing tests, such as:

    1. Execute this method:org.apache.inlong.manager.client.File2HudiExample#testCreateGroupForHudi, an exception will occur in manager all log. Please refer to [Bug][Sort] Related problem with attribute exceptions when creating 'hudiSink' #9333 for detailed error logs;
    2. After adding the code I added, the task can be successfully created
  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang merged commit 5ff109f into apache:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Sort] Related problem with attribute exceptions when creating 'hudiSink'
4 participants