[INLONG-9009][Sort] Add HBase source and sink connector on flink 1.15 #9043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some tests on this connector thanks |
vernedeng
reviewed
Oct 12, 2023
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/hbase/pom.xml
Outdated
Show resolved
Hide resolved
vernedeng
reviewed
Oct 12, 2023
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/hbase/pom.xml
Outdated
Show resolved
Hide resolved
EMsnap
reviewed
Oct 16, 2023
...t-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/HBase2DynamicTableFactory.java
Outdated
Show resolved
Hide resolved
EMsnap
reviewed
Oct 16, 2023
...-end-to-end-tests-v1.15/src/test/java/org/apache/inlong/sort/tests/utils/HBaseContainer.java
Outdated
Show resolved
Hide resolved
EMsnap
reviewed
Oct 16, 2023
.../sort-end-to-end-tests/sort-end-to-end-tests-v1.15/src/test/resources/flinkSql/hbase_e2e.sql
Outdated
Show resolved
Hide resolved
vernedeng
approved these changes
Oct 16, 2023
dockerzhang
approved these changes
Oct 16, 2023
yunqingmoswu
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Add HBase source and sink connector on flink 1.15
Modifications
Add HBase source and sink connector on flink 1.15
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation
#####################################################################################################
I have some trouble to write the end-to-end test for HBase. So I just run some tests in flink(v1.15) bin/sql-client.sh. I will consider adding end-to-end testing.
Sink:
Source: