Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8655][Agent] Fix bug: JobWrapper thread leaks when the job is stopped #8656

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

justinwwhuang
Copy link
Contributor

Prepare a Pull Request

Motivation

fix bug: JobWrapper thread leaks when the job is stopped

Modifications

  • clear JobWrapper::allTasks in the cleanup function*

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang changed the title [INLONG-8655][Agent] fix bug: JobWrapper thread leaks when the job is stopped [INLONG-8655][Agent] Fix bug: JobWrapper thread leaks when the job is stopped Aug 7, 2023
@dockerzhang
Copy link
Contributor

Run 'mvn spotless:apply' to fix the check style issues.

@dockerzhang dockerzhang merged commit 11a5b40 into apache:master Aug 8, 2023
@justinwwhuang justinwwhuang deleted the develop branch August 8, 2023 02:39
kuansix pushed a commit to kuansix/inlong that referenced this pull request Aug 8, 2023
ZhaoNiuniu pushed a commit to ZhaoNiuniu/inlong that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Agent] JobWrapper thread leaks when the job is stopped
4 participants