Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8500][Dashboard] Fix stream data preview url error #8501

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

haifxu
Copy link
Contributor

@haifxu haifxu commented Jul 11, 2023

Prepare a Pull Request

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

/stream/queryMessage -> /stream/listMessage

Verifying this change

  • This change is a trivial rework/code cleanup without any test coverage.

@dockerzhang dockerzhang merged commit 358c018 into apache:master Jul 11, 2023
@hnrainll
Copy link
Contributor

@haifxu Hi, I see the link is still faulty.

/stream/queryMessage -> /stream/listMessages not /stream/listMessage
and the request parameters are groupId, streamId, messageCount instead of groupId, streamId, position.

The server-side code is as follows:
https://github.com/apache/inlong/blob/master/inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongStreamController.java#L238

@haifxu
Copy link
Contributor Author

haifxu commented Jul 11, 2023

@haifxu Hi, I see the link is still faulty.

/stream/queryMessage -> /stream/listMessages not /stream/listMessage and the request parameters are groupId, streamId, messageCount instead of groupId, streamId, position.

The server-side code is as follows: https://github.com/apache/inlong/blob/master/inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongStreamController.java#L238

Thank you for correcting my mistake. I will fix it. : )

ZhaoNiuniu pushed a commit to ZhaoNiuniu/inlong that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Dashboard] Fix stream data preview url error
5 participants