Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-8252][DataProxy] Adjust default Topic settings from Source to Sink #8259

Merged
merged 1 commit into from
Jun 15, 2023
Merged

[INLONG-8252][DataProxy] Adjust default Topic settings from Source to Sink #8259

merged 1 commit into from
Jun 15, 2023

Conversation

gosonzhang
Copy link
Contributor

  1. Adjust the setting Key of the default Topic;
  2. Delete the default Topic setting logic on the Source side;
  3. Increase the processing of the default Topic on the Sink side;
  4. Adjust the indicator management and log printing frequency
  5. Add comments and remove unreferenced KEYs

luchunliang
luchunliang approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baomingyu
baomingyu approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@baomingyu baomingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit a629f1c into apache:master Jun 15, 2023
@gosonzhang gosonzhang deleted the INLONG-8252 branch June 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baomingyu baomingyu baomingyu approved these changes

@luchunliang luchunliang luchunliang approved these changes

Assignees
No one assigned
Labels
component/dataproxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][DataProxy] Adjust default Topic settings from Source to Sink
3 participants
@gosonzhang @baomingyu @luchunliang