Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8146][Agent] Add -XX:NativeMemoryTracking in agent-env.sh #8147

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

kipshi
Copy link
Contributor

@kipshi kipshi commented Jun 2, 2023

Prepare a Pull Request

Motivation

Add this params, we can use 'jcmd VM.native_memory summary' to analyze Off-Heap Memory

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@gong
Copy link
Contributor

gong commented Jun 2, 2023

Maybe using the -XX:NativeMemoryTracking parameter during testing and diagnosis, rather than in production environments, to avoid affecting application performance.

@healchow healchow changed the title [INLONG-8146][Agent] add -XX:NativeMemoryTracking in agent-env.sh [INLONG-8146][Agent] Add -XX:NativeMemoryTracking in agent-env.sh Jun 4, 2023
@healchow
Copy link
Member

healchow commented Jun 4, 2023

Maybe using the -XX:NativeMemoryTracking parameter during testing and diagnosis, rather than in production environments, to avoid affecting application performance.

Can we pass in environmental conditions at startup to determine whether to enable this parameter?

@dockerzhang dockerzhang requested review from gong and healchow June 15, 2023 07:42
@dockerzhang dockerzhang merged commit c94f018 into apache:master Jul 13, 2023
vernedeng pushed a commit that referenced this pull request Jul 13, 2023
ZhaoNiuniu pushed a commit to ZhaoNiuniu/inlong that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Optimize agent-env.sh, and '-XX:NativeMemoryTracking'
4 participants