[INLONG-5192][DataProxy] Add unit test for TubeMQ sink #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healchow
reviewed
Jul 27, 2022
...-dataproxy/dataproxy-source/src/test/java/org/apache/inlong/dataproxy/sink/TestTubeSink.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Jul 27, 2022
...-dataproxy/dataproxy-source/src/test/java/org/apache/inlong/dataproxy/sink/TestTubeSink.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Jul 27, 2022
...-dataproxy/dataproxy-source/src/test/java/org/apache/inlong/dataproxy/sink/TestTubeSink.java
Outdated
Show resolved
Hide resolved
healchow
reviewed
Jul 27, 2022
...-dataproxy/dataproxy-source/src/test/java/org/apache/inlong/dataproxy/sink/TestTubeSink.java
Outdated
Show resolved
Hide resolved
baomingyu
reviewed
Jul 27, 2022
...-dataproxy/dataproxy-source/src/test/java/org/apache/inlong/dataproxy/sink/TestTubeSink.java
Show resolved
Hide resolved
healchow
approved these changes
Jul 27, 2022
|
@liangyepianzhou please format the |
I have already fixed the comments given by healchow. |
|
Yes, the new file |
dockerzhang
approved these changes
Jul 27, 2022
Greedyu
pushed a commit
to Greedyu/inlong
that referenced
this pull request
Jul 31, 2022
bruceneenhl
pushed a commit
to bruceneenhl/inlong
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Add test for tube sink. KafkaSink has not been implemented yet, so test TubeSink first.
Modifications
Add test for tube sink. KafkaSink has not been implemented yet, so test TubeSink first.
Verifying this change
(Please pick either of the following options)