Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-5178][Manager] Optimize Warning info for the Manager module #5186

Conversation

liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Jul 22, 2022

Prepare a Pull Request

Motivation

Optimize Warning info when compiling the Manager module

Modifications

Optimize Warning info when compiling the Manager module

Verifying this change

  • This change is a trivial rework/code cleanup without any test coverage.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! 💖 This seems to be your first PR! 🌠 Please be sure to follow our contribution guidelines! 🎁

@liangyepianzhou
Copy link
Contributor Author

liangyepianzhou commented Jul 22, 2022

@dockerzhang @healchow Could you please take a look when you have time?

@liangyepianzhou liangyepianzhou changed the title [Improve][Manager] Optimize Warning info when compiling the Manager module [Improve][Manager] Optimize Warning info for the Manager module Jul 22, 2022
@liangyepianzhou liangyepianzhou changed the title [Improve][Manager] Optimize Warning info for the Manager module [INLONG-5178][Manager] Optimize Warning info for the Manager module Jul 22, 2022
@dockerzhang
Copy link
Contributor

@liangyepianzhou there are failed UTs. Please check again.

@liangyepianzhou
Copy link
Contributor Author

The Builder.Default is not appended into InlongPulsarInfo.
Because its method genRequest needs to copy properties. if it adds @Builder.Default, the variables will get null.

@Override
public InlongPulsarRequest genRequest() {
    return CommonBeanUtils.copyProperties(this, InlongPulsarRequest::new);
}

@dockerzhang
Copy link
Contributor

@liangyepianzhou there still are lots of warnings for Builder.Default. Please check the workflow again.

@dockerzhang
Copy link
Contributor

[INFO] Compiling 332 source files to /home/runner/work/inlong/inlong/inlong-manager/manager-common/target/classes
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[55,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[58,17] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[61,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[64,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[67,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[70,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[73,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[76,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[79,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[82,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[85,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.

@liangyepianzhou
Copy link
Contributor Author

[INFO] Compiling 332 source files to /home/runner/work/inlong/inlong/inlong-manager/manager-common/target/classes
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[55,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[58,17] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[61,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[64,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[67,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[70,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[73,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[76,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[79,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[82,21] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.
Warning:  /home/runner/work/inlong/inlong/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/pulsar/InlongPulsarInfo.java:[85,20] @SuperBuilder will ignore the initializing expression entirely. If you want the initializing expression to serve as default, add @Builder.Default. If it is not supposed to be settable during building, make the field final.

@dockerzhang
I have commented that the inlongPulsarinfo will not add @Builder.Default.

@dockerzhang dockerzhang requested a review from kipshi July 26, 2022 03:12
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow merged commit cde59a9 into apache:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] There is so much Warning info when compiling the Manager module
4 participants