Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-5117][SortStandalone] Support specify component type from remote config #5134

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

vernedeng
Copy link
Contributor

Motivation

Current config loading strategy restricts the flexibility of sort-standalone by naming the only type of components in config file. Which means one sort-standalone node can only support a series of tasks with the same type of sink.
By specify this params into SortTask, the sort-standalone will be decoupled from node to task.

Modifications

allow sort-standalone get type of components from remote config

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit 206a7ad into apache:master Jul 20, 2022
bruceneenhl pushed a commit to bruceneenhl/inlong that referenced this pull request Aug 12, 2022
@vernedeng vernedeng deleted the INLONG-5117 branch May 26, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort-Standalone] Support specify component type from remote config
4 participants