Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-4777][SortStandalone] Change ack policy from checking message count to checking every message #4778

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

luchunliang
Copy link
Contributor

Prepare a Pull Request

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow healchow changed the title [INLONG-4777][SortStandalone] SortStandalone change ack policy: from checking message count to checking every message. [INLONG-4777][Sort-Standalone] Change ack policy from checking message count to checking every message Jun 25, 2022
@luchunliang luchunliang changed the title [INLONG-4777][Sort-Standalone] Change ack policy from checking message count to checking every message [INLONG-4777][SortStandalone] Change ack policy from checking message count to checking every message Jun 25, 2022
@dockerzhang dockerzhang merged commit f8c46a6 into apache:master Jun 30, 2022
vernedeng pushed a commit to vernedeng/incubator-inlong that referenced this pull request Jul 4, 2022
bruceneenhl pushed a commit to bruceneenhl/inlong that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort-Standalone] Change ack policy from checking message count to checking every message
4 participants