Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-10476][Agent] The audit address should only be obtained from the manager #10477

Merged
merged 2 commits into from
Jun 21, 2024
Merged

[INLONG-10476][Agent] The audit address should only be obtained from the manager #10477

merged 2 commits into from
Jun 21, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Jun 21, 2024 •
edited
Loading

Fixes #10476

Motivation

The audit address should only be obtained from the manager

Modifications

  1. Delete the code for obtaining audit addresses from the configuration file
  2. Delete audit cache related code

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@justinwwhuang justinwwhuang added this to the 1.13.0 milestone Jun 21, 2024
@justinwwhuang justinwwhuang requested a review from aloyszhang June 21, 2024 02:59
@justinwwhuang justinwwhuang self-assigned this Jun 21, 2024
@dockerzhang dockerzhang merged commit 79eba73 into apache:master Jun 21, 2024
7 checks passed
@justinwwhuang justinwwhuang deleted the b10476 branch June 21, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosonzhang gosonzhang gosonzhang approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@doleyzi doleyzi Awaiting requested review from doleyzi

@aloyszhang aloyszhang Awaiting requested review from aloyszhang

Assignees

@justinwwhuang justinwwhuang

Labels
component/agent
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] The audit address should only be obtained from the manager
3 participants
@justinwwhuang @gosonzhang @dockerzhang