Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-542] Ensure the elements of StatusCode and RssProtos.StatusCode are the same #543

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

xianjingfeng
Copy link
Member

@xianjingfeng xianjingfeng commented Feb 2, 2023

What changes were proposed in this pull request?

Ensure the elements of StatusCode and RssProtos.StatusCode are the same

Why are the changes needed?

It may cause bugs, Fix #542

Does this PR introduce any user-facing change?

No

How was this patch tested?

UTs

@xianjingfeng xianjingfeng changed the title [ISSUE-542] Ensure StatusCode and RssProtos.StatusCode are the same [ISSUE-542] Ensure the elements of StatusCode and RssProtos.StatusCode are the same Feb 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #543 (40f27b2) into master (ebbe2db) will decrease coverage by 0.98%.
The diff coverage is 11.53%.

@@             Coverage Diff              @@
##             master     #543      +/-   ##
============================================
- Coverage     60.21%   59.24%   -0.98%     
- Complexity     1784     1787       +3     
============================================
  Files           205      213       +8     
  Lines         11557    12349     +792     
  Branches       1042     1042              
============================================
+ Hits           6959     7316     +357     
- Misses         4190     4625     +435     
  Partials        408      408              
Impacted Files Coverage Δ
...pache/uniffle/server/ShuffleServerGrpcService.java 0.80% <0.00%> (+0.01%) ⬆️
...ain/java/org/apache/uniffle/server/StatusCode.java 93.75% <75.00%> (+1.44%) ⬆️
...y/kubernetes/operator/pkg/webhook/inspector/rss.go 47.70% <0.00%> (ø)
...a/org/apache/uniffle/common/ShuffleServerInfo.java 75.00% <0.00%> (ø)
...pache/uniffle/server/ShuffleServerGrpcMetrics.java 100.00% <0.00%> (ø)
.../apache/uniffle/coordinator/ClientConfManager.java 92.95% <0.00%> (ø)
...fle/coordinator/metric/CoordinatorGrpcMetrics.java 100.00% <0.00%> (ø)
...inator/access/checker/AccessCandidatesChecker.java 85.50% <0.00%> (ø)
...eploy/kubernetes/operator/pkg/utils/coordinator.go 0.00% <0.00%> (ø)
deploy/kubernetes/operator/pkg/utils/rss.go 100.00% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 0ad8a15 into apache:master Feb 2, 2023
@xianjingfeng xianjingfeng deleted the issue_542 branch August 9, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Ensure that the elements of StatusCode and RssProtos.StatusCode are the same
4 participants