[ISSUE-553] Avoid removing buffer multiple times when clearing resources

[xianjingfeng]

What changes were proposed in this pull request?

Avoid remove buffer multiple times when clear resource

Why are the changes needed?

This will cause memory to be released multiple times, Fix #533

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

[codecov-commenter]

Codecov Report

Merging #534 (e75bce9) into master (ebbe2db) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #534      +/-   ##
============================================
- Coverage     60.21%   60.21%   -0.01%     
  Complexity     1784     1784              
============================================
  Files           205      205              
  Lines         11557    11556       -1     
  Branches       1042     1042              
============================================
- Hits           6959     6958       -1     
  Misses         4190     4190              
  Partials        408      408              

Impacted Files	Coverage Δ
...he/uniffle/server/buffer/ShuffleBufferManager.java	83.27% <100.00%> (-0.06%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[advancedxy]

Seems there are multiple instances for this double release.
Is it possible to add a ut to simulate the long app clean situation and make sure we don't encounter this problem later.

if is too much trouble, we than defer that in later improvement.

[zuston]

LGTM.

Seems there are multiple instances for this double release.
Is it possible to add a ut to simulate the long app clean situation and make sure we don't encounter this problem later.
if is too much trouble, we than defer that in later improvement.

+1. I will merge this if it still has too much work to do when adding tests.

[xianjingfeng]

Seems there are multiple instances for this double release. Is it possible to add a ut to simulate the long app clean situation and make sure we don't encounter this problem later.

if is too much trouble, we than defer that in later improvement.

I will try to add this ut in this pr.

[xianjingfeng]

Similar ut already exist before.

incubator-uniffle/server/src/test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java

Line 576 in 67d1559

public void clearMultiTimesTest() throws Exception {

And a new ut is added for this pr. PTAL. @zuston @advancedxy

[zuston]

LGTM

[zuston]

Thanks @xianjingfeng @advancedxy. Merged.