Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Test: AppBalanceSelectStorageStrategyTest#selectStorageTest #450

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

smallzhongfeng
Copy link
Contributor

What changes were proposed in this pull request?

When testing, close the scheduler thread detectStorageScheduler.

Why are the changes needed?

When testing, in order to ensure that multiple paths are normal, the method of manually scheduling detectStorage is used.

applicationManager.getRemoteStoragePathRankValue().get(remotePath1).getCostTime().set(0);
applicationManager.getRemoteStoragePathRankValue().get(remotePath2).getCostTime().set(0); 

The original repair may still fail to write the hdfs file later.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

origin uts.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #450 (18c10af) into master (fa364c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #450      +/-   ##
============================================
- Coverage     58.72%   58.72%   -0.01%     
  Complexity     1652     1652              
============================================
  Files           199      199              
  Lines         11212    11214       +2     
  Branches        996      996              
============================================
+ Hits           6584     6585       +1     
  Misses         4237     4237              
- Partials        391      392       +1     
Impacted Files Coverage Δ
...apache/uniffle/coordinator/ApplicationManager.java 84.39% <100.00%> (+0.18%) ⬆️
...ategy/storage/AppBalanceSelectStorageStrategy.java 72.00% <0.00%> (-2.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @smallzhongfeng

@jerqi jerqi merged commit 3ef80ed into apache:master Dec 29, 2022
@smallzhongfeng
Copy link
Contributor Author

Thanks for your review. @jerqi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants