-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test QuotaManagerTest#testDetectUserResource #421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
============================================
- Coverage 58.54% 58.41% -0.13%
- Complexity 1611 1612 +1
============================================
Files 195 195
Lines 11035 11063 +28
Branches 966 976 +10
============================================
+ Hits 6460 6463 +3
- Misses 4195 4221 +26
+ Partials 380 379 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @xianjingfeng for the work. A few suggestions here:
static IntStream range() {
return IntStream.range(0, 100);
}
@ParameterizedTest
@MethodSource("range")
public void testDetectUserResource(int dummy) throws Exception { The test result (before the change): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xianjingfeng.
What changes were proposed in this pull request?
Fix flaky test QuotaManagerTest#testDetectUserResource
Why are the changes needed?
The process of parsing quota file is asynchronous.
https://github.com/apache/incubator-uniffle/actions/runs/3695326069/jobs/6257565865
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need