-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-283][FEATURE] Support snappy compression/decompression #304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
============================================
- Coverage 60.76% 60.70% -0.06%
- Complexity 1454 1459 +5
============================================
Files 179 180 +1
Lines 9201 9223 +22
Branches 882 886 +4
============================================
+ Hits 5591 5599 +8
- Misses 3316 3325 +9
- Partials 294 299 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should we modify the document about |
@jerqi Yes! I updated that config's description accordingly. |
137d721
to
ac57c13
Compare
The failing test seems to be flaky. What is the way to re-trigger the test? |
I have re-triggered the test. It passed. You can close and reopen the pr to re-trigger the all the tests. It seems that only committers can re-trigger the single test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @amaliujia
What changes were proposed in this pull request?
This PR adds the support of snappy compression/decompression based on the example of #254.
Why are the changes needed?
Add a new feature.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT