Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2288] feat(dashboard): Show nodeInfo in excludeNode page #2289

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kuszz
Copy link
Contributor

@kuszz kuszz commented Dec 12, 2024

What changes were proposed in this pull request?

Show nodeInfo in excludeNode page
image

企业微信截图_b08453cf-21af-43ed-bcdd-4238390c9823

Why are the changes needed?

Fix: #2288

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Copy link

github-actions bot commented Dec 12, 2024

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 27m 14s ⏱️ - 6m 47s
 1 096 tests ±0   1 094 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 735 runs  ±0  13 705 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 4b5f339. ± Comparison against base commit b7c9ca5.

♻️ This comment has been updated with latest results.

@jerqi
Copy link
Contributor

jerqi commented Dec 12, 2024

@yl09099 Could you help review this pull request?

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yl09099
Copy link
Contributor

yl09099 commented Dec 13, 2024

Why is your image above in the active option with add and delete buttons?

@kuszz
Copy link
Contributor Author

kuszz commented Dec 17, 2024

Why is your image above in the active option with add and delete buttons?

@yl09099 I have changed the image, the add and delete buttons only in exclude node page

@jerqi
Copy link
Contributor

jerqi commented Dec 17, 2024

@yl09099 Do you have another suggestion?

@yl09099
Copy link
Contributor

yl09099 commented Dec 17, 2024

LGTM

@jerqi jerqi merged commit 258db12 into apache:master Dec 18, 2024
43 checks passed
@jerqi
Copy link
Contributor

jerqi commented Dec 18, 2024

Merged. Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add node info in excludeNode page, remove ExcludeNodeList.vue
3 participants