[ISSUE-48][FEATURE][FOLLOW UP] Add webhook component #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zuston @thousandhu @czy006 Could you help me review this patch? |
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=========================================
Coverage 58.41% 58.41%
Complexity 1271 1271
=========================================
Files 158 158
Lines 8428 8428
Branches 782 782
=========================================
Hits 4923 4923
Misses 3253 3253
Partials 252 252 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
reviewed
Aug 26, 2022
03d309f to
1c08d0f
Compare
thousandhu
reviewed
Aug 30, 2022
1c08d0f to
000c8a8
Compare
|
LGTM, +1 |
jerqi
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
LGTM, thanks @wangao1236 @thousandhu , @zuston @czy006 if you have another suggestion, you can raise a new pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
for issue #48
I add webhook module this time, maybe some logic is missing unit test, I will add in the next PR.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?