[#1755] fix(spark): Avoid task failure of inconsistent record number #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyma
reviewed
May 30, 2024
| partitionList.sort( | ||
| Comparator.comparingInt(o -> buffers.get(o) == null ? 0 : buffers.get(o).getMemoryUsed()) | ||
| .reversed()); | ||
| if (bufferSpillRatio != 1.0) { |
There was a problem hiding this comment.
We don't need this line, we already have if (Double.compare(bufferSpillRatio, 1.0) < 0) {
More validation mechanisms should be added |
rickyma
approved these changes
May 30, 2024
jerqi
approved these changes
May 30, 2024
cherry-pick failure to branch 0.9 |
|
@zuston Can we add a new PR to branch 0.9. It is a critical fix. |
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Dec 9, 2024
…umber (apache#1756) ### What changes were proposed in this pull request? 1. When the spill ratio is `1.0` , the process of calculating target spill size will be ignored to avoid potential race condition that the `usedBytes` and `inSendBytes` are not thread safe. This could guarantee that the all data is flushed to the shuffle server at the end of task. 2. Adding the `bufferManager's` buffer remaining check ### Why are the changes needed? Due to the apache#1670 , the partial data held by the bufferManager will not be flushed to shuffle servers in some corner cases, this will make task fail fast rather than silently data loss that should thanks the apache#1558 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1.0, the process of calculating target spill size will be ignored to avoid potential race condition that theusedBytesandinSendBytesare not thread safe. This could guarantee that the all data is flushed to the shuffle server at the end of task.bufferManager'sbuffer remaining checkWhy are the changes needed?
Due to the #1670 , the partial data held by the bufferManager will not be flushed to shuffle servers in some corner cases,
this will make task fail fast rather than silently data loss that should thanks the #1558
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.