[MINOR] fix(dashboard): Display the registration time in 24-hour format #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yl09099 PTAL. |
Test Results 2 411 files - 8 2 411 suites - 8 4h 57m 4s ⏱️ - 3m 3s For more details on these errors, see this check. Results for commit 4271744. ± Comparison against base commit 417674d. |
|
LGTM~ |
|
@yl09099 You can approve this. I've already tested this. |
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 2, 2024
…at (#1752) ### What changes were proposed in this pull request? Display the registration time in 24-hour format. ### Why are the changes needed? The current displayed registration time follows the system time of the machine. If the system is set to a 12-hour format, then the page will display the time in a 12-hour format. If the system is set to a 24-hour format, then the page will display the time in a 24-hour format. It's not clear in the UI whether it's AM or PM when the Linux machine uses the 12-hour format. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Display the registration time in 24-hour format.
Why are the changes needed?
The current displayed registration time follows the system time of the machine. If the system is set to a 12-hour format, then the page will display the time in a 12-hour format. If the system is set to a 24-hour format, then the page will display the time in a 24-hour format. It's not clear in the UI whether it's AM or PM when the Linux machine uses the 12-hour format.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.