Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] test: Use sensible partition ids in ShuffleReadClientImplTest #1545

Merged

Conversation

EnricoMi
Copy link
Contributor

What changes were proposed in this pull request?

Explicitly uses partition id 0 or 1 where sensible. Also adds a test that writes and reads two partitions.

Why are the changes needed?

In ShuffleReadClientImplTest, partition id 0 is implicitly used though some tests use HadoopShuffleWriteHandler with partition id 1, which is not realistic.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit tests.

Copy link

github-actions bot commented Feb 27, 2024

Test Results

2 312 files  ± 0  2 312 suites  ±0   4h 37m 23s ⏱️ + 1m 2s
  823 tests + 1    822 ✅ + 1   1 💤 ±0  0 ❌ ±0 
9 693 runs  +14  9 679 ✅ +14  14 💤 ±0  0 ❌ ±0 

Results for commit c720b10. ± Comparison against base commit a73dcb9.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi force-pushed the shuffle-read-client-impl-test-partitions branch from a4622b4 to c720b10 Compare February 27, 2024 09:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.57%. Comparing base (a73dcb9) to head (c720b10).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1545      +/-   ##
============================================
+ Coverage     53.62%   54.57%   +0.95%     
  Complexity     2816     2816              
============================================
  Files           436      416      -20     
  Lines         24536    22175    -2361     
  Branches       2076     2076              
============================================
- Hits          13157    12103    -1054     
+ Misses        10559     9322    -1237     
+ Partials        820      750      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @EnricoMi

@jerqi jerqi merged commit 12f9271 into apache:master Feb 28, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants