[#1476] feat(spark): Provide dedicated unregister app rpc interface #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiqi You <2810592075@qq.com>
Signed-off-by: Yiqi You <2810592075@qq.com>
jerqi
reviewed
Feb 6, 2024
zuston
reviewed
Feb 6, 2024
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java
Outdated
Show resolved
Hide resolved
Test Results2 287 files 2 287 suites 4h 27m 51s ⏱️ Results for commit 84e0434. ♻️ This comment has been updated with latest results. |
Signed-off-by: Yiqi You <2810592075@qq.com>
Signed-off-by: Yiqi You <2810592075@qq.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1510 +/- ##
=============================================
+ Coverage 0 55.19% +55.19%
- Complexity 0 2809 +2809
=============================================
Files 0 410 +410
Lines 0 22049 +22049
Branches 0 2082 +2082
=============================================
+ Hits 0 12170 +12170
- Misses 0 9121 +9121
- Partials 0 758 +758 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yiqi You <2810592075@qq.com>
Signed-off-by: Yiqi You <2810592075@qq.com>
|
Merged. Thanks for your contribution @somelovelanguage . Welcome to Uniffle community! 🎉 |
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Mar 19, 2024
…face (apache#1510) ### What changes were proposed in this pull request? Introduce dedicated unregisterApp rpc interface which is only called once when unregister shuffle ### Why are the changes needed? Fix: [apache#1476](apache#1476) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce dedicated unregisterApp rpc interface which is only called once when unregister shuffle
Why are the changes needed?
Fix: #1476
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT