[#1464] improvement(spark): Improve the error log message for checkBlockSendResult #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119ca8b to
09a7633
Compare
09a7633 to
ecc1756
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1465 +/- ##
============================================
+ Coverage 54.15% 55.14% +0.99%
- Complexity 2773 2774 +1
============================================
Files 423 403 -20
Lines 24204 21843 -2361
Branches 2061 2061
============================================
- Hits 13107 12045 -1062
+ Misses 10285 9057 -1228
+ Partials 812 741 -71 ☔ View full report in Codecov by Sentry. |
…checkBlockSendResult
ecc1756 to
758a1f1
Compare
…checkBlockSendResult
64cc170 to
7b3532b
Compare
jerqi
approved these changes
Jan 17, 2024
zuston
approved these changes
Jan 18, 2024
|
Merged. Thanks @rickyma |
jerqi
pushed a commit
that referenced
this pull request
Jan 22, 2024
…that blocks fail to send (#1473) ### What changes were proposed in this pull request? The output of failed shuffle servers' result has not been successfully deduplicated. ### Why are the changes needed? It's a followup PR for [#1465](#1465). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the error log message for checkBlockSendResult.
As described in #1464, it will print out the shuffle server's IP and ports.
Why are the changes needed?
For #1464
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.