[JUnit] Introduce the property of trimStackTrace to show error stacktrace in mvn-test #126
Conversation
|
Could you show me the effect of this plugin by you own Github action? like #122 |
|
If you want to see the log, you can download https://github.com/apache/incubator-uniffle/actions/runs/2779258464 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 57.17% 57.17%
Complexity 1201 1201
=========================================
Files 150 150
Lines 8178 8178
Branches 773 773
=========================================
Hits 4676 4676
Misses 3256 3256
Partials 246 246 ☔ View full report in Codecov by Sentry. |
|
The failed test cases stracktrace will be shown in artifacts? I didn’t find. And i think it’s meaningful to allow user to specify the config to control the stacktrace output. |
Yes, Click the link which I give you, and Search Artifacts, you can find it. |
|
Recheck the log in artifact, still not found the junit test case error detailed stacktrace. Refer: https://stackoverflow.com/questions/2928548/make-mavens-surefire-show-stacktrace-in-console |
Could you give me an example? |
|
The default value of trimStackTrace is true, which will not output the error stackstrace. But when we execute the command of
Ok, it will change the default value to false. |
|
The artifact log which I give you have these logs, you can find it in *.out. |
|
Due to this PR, so the detailed log can be shown in the console and output log. |
I don't use your pr. |
|
Updated @jerqi |
integration-test/common/pom.xml
Outdated
| @@ -144,6 +144,7 @@ | |||
| <useFile>${test.redirectToFile}</useFile> | |||
| <argLine>-ea -Xmx3g</argLine> | |||
| <failIfNoTests>false</failIfNoTests> | |||
| <trimStackTrace>${trimStackTrace}</trimStackTrace> | |||
There was a problem hiding this comment.
Why do we need this? Is it enough to change parent pom file? And why do we only modify common, mr, spark-common? How about spark2 and spark3?
There was a problem hiding this comment.
Tested. The trimStackTrace in parent pom is enough.
What changes were proposed in this pull request?
[JUnit] Introduce the property of trimStackTrace to show error stacktrace in mvn-test
Why are the changes needed?
When acting mvn test in current codebase, it will not throw detailed stacktrace about failed UTs and make hard to debug. So introduce this property of trimStackTrace to allow user to show the complete stacktrace.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
CI Before this PR
After