Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test: ShuffleBufferManagerTest#cacheShuffleDataTest #507

Closed
2 of 3 tasks
kaijchen opened this issue Jan 20, 2023 · 0 comments · Fixed by #511
Closed
2 of 3 tasks

Flaky Test: ShuffleBufferManagerTest#cacheShuffleDataTest #507

kaijchen opened this issue Jan 20, 2023 · 0 comments · Fixed by #511

Comments

@kaijchen
Copy link
Contributor

kaijchen commented Jan 20, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the flaky test

Error:  Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.848 s <<< FAILURE! - in org.apache.uniffle.server.buffer.ShuffleBufferManagerTest
Error:  cacheShuffleDataTest  Time elapsed: 1.694 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <0> but was: <-3>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:527)
	at org.apache.uniffle.server.buffer.ShuffleBufferManagerTest.cacheShuffleDataTest(ShuffleBufferManagerTest.java:307)

Actions URL

https://github.com/apache/incubator-uniffle/actions/runs/3965932842/jobs/6796171397

Parent issue

#1733

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@kaijchen kaijchen mentioned this issue Jan 28, 2023
Merged
advancedxy pushed a commit that referenced this issue Jan 29, 2023
@xianjingfeng @kaijchen
[ISSUE-507] Fix Flaky Test: ShuffleBufferManagerTest#cacheShuffleData…
cd2662f 
…Test (#511)

### What changes were proposed in this pull request?
Fix Flaky Test: ShuffleBufferManagerTest#cacheShuffleDataTest.

### Why are the changes needed?
It is flaky Test. Fix #507 

I found logs as follows in `org.apache.uniffle.server.buffer.ShuffleBufferManagerTest-output.txt`.
```
2023-01-28 09:24:40,791 INFO  [expiredAppCleaner] server.ShuffleTaskManager (ShuffleTaskManager.java:checkResourceStatus(511)) - Detect expired appId[removeShuffleDataTest1] according to rss.server.app.expired.withoutHeartbeat
```

So i think the reason is that some threads have not exit after running `ShuffleTaskManagerTest#removeShuffleDataWithHdfsTest`.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
No need

Co-authored-by: Kaijie Chen <ckj@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kaijchen