Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Catch NPE in org.apache.uniffle.server.ShuffleTaskManager#addFinishedBlockIds #329

Closed
3 tasks done
xianjingfeng opened this issue Nov 16, 2022 · 0 comments · Fixed by #331
Closed
3 tasks done

[Improvement] Catch NPE in org.apache.uniffle.server.ShuffleTaskManager#addFinishedBlockIds #329

xianjingfeng opened this issue Nov 16, 2022 · 0 comments · Fixed by #331

Comments

@xianjingfeng
Copy link
Member

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

reportShuffleResult after app expired in shuffle server will throw NPE.

[ERROR] 2022-11-16 08:34:17,365 Grpc-36 ShuffleServerGrpcService reportShuffleResult - Error happened when report shuffle result for appId[application_1662640300316_225642511668556895849], shuffleId[18], taskAttemptId[58606] java.lang.NullPointerException

How should we improve?

If app expired, thrown a runtime exception with message

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@xianjingfeng xianjingfeng mentioned this issue Nov 16, 2022
Merged
@jerqi jerqi linked a pull request Nov 16, 2022 that will close this issue
[ISSUE-329]Catch NPE in ShuffleTaskManager#addFinishedBlockIds #331
Merged
jerqi pushed a commit that referenced this issue Nov 16, 2022
@xianjingfeng
[ISSUE-329][Bug] Catch NPE in org.apache.uniffle.server.ShuffleTaskMa…
9f0610a 
…nager#addFinishedBlockIds (#331)

### What changes were proposed in this pull request?
If app expired, thrown a runtime exception with message

### Why are the changes needed?
`reportShuffleResult` after app expired in shuffle server will throw NPE #329  

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE-329]Catch NPE in ShuffleTaskManager#addFinishedBlockIds xianjingfeng/incubator-uniffle
1 participant
@xianjingfeng