Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Shuffle server hang due to log4j callAppenders #1910

Closed
3 tasks done
zuston opened this issue Jul 16, 2024 · 0 comments · Fixed by #1911
Closed
3 tasks done

[Bug] Shuffle server hang due to log4j callAppenders #1910

zuston opened this issue Jul 16, 2024 · 0 comments · Fixed by #1911

Comments

@zuston
Copy link
Member

zuston commented Jul 16, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

Shuffle server hangs due to the log4j callAppenders

"Grpc-485" #947 daemon prio=5 os_prio=0 cpu=1573643.15ms elapsed=2321982.00s tid=0x00007f8240577800 nid=0x31de10 waiting for monitor entry  [0x00007f81ece53000]
   java.lang.Thread.State: BLOCKED (on object monitor)
        at org.apache.log4j.Category.callAppenders(Category.java:204)
        - waiting to lock <0x00007f82dc778c40> (a org.apache.log4j.spi.RootLogger)
        at org.apache.log4j.Category.forcedLog(Category.java:384)
        at org.apache.log4j.Category.log(Category.java:810)
        at org.slf4j.impl.Reload4jLoggerAdapter.info(Reload4jLoggerAdapter.java:347)
        at org.apache.uniffle.server.ShuffleServerGrpcService.reportShuffleResult(ShuffleServerGrpcService.java:493)
        at org.apache.uniffle.proto.ShuffleServerGrpc$MethodHandlers.invoke(ShuffleServerGrpc.java:1134)
        at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182)
        at io.grpc.PartialForwardingServerCallListener.onHalfClose(PartialForwardingServerCallListener.java:35)
        at io.grpc.ForwardingServerCallListener.onHalfClose(ForwardingServerCallListener.java:23)
        at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:352)
        at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:866)
        at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
        at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.4/ThreadPoolExecutor.java:1128)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.4/ThreadPoolExecutor.java:628)
        at java.lang.Thread.run(java.base@11.0.4/Thread.java:834)

From the log4j document, we should not print out the method name into the log4j properties.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zuston zuston closed this as completed in bb1eaa2 Jul 17, 2024
zhengchenyu pushed a commit that referenced this issue Aug 9, 2024
### What changes were proposed in this pull request?

From the log4j document, we should not print out the method name into the log4j properties.

### Why are the changes needed?

Fix: #1910

Refer to: https://logging.apache.org/log4j/2.x/performance.html#asynchronous-logging-with-caller-location-information

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Needn't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant