Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support pending for ShuffleDataFlushEvent in DefaultFlushEventHandler #1460

Closed
2 of 3 tasks
zuston opened this issue Jan 17, 2024 · 0 comments
Closed
2 of 3 tasks

Comments

@zuston
Copy link
Member

zuston commented Jan 17, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

Currently, the event will be discarded when flushing failure happens. This is not friendly for flushing to HDFS that is not stable.

I think this features should be supported after #1459 done

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zuston added a commit that referenced this issue Jan 18, 2024
…pport event retry into pending queue (#1461)

### What changes were proposed in this pull request?

1. Refactor DefaultFlushEventHandler to unify the logic of handling event
2. Fix incorrect some metrics 
3. Support retry event into pending queue
4. Fix the incorrect inFlushQueueSize
5. Introduce the underlying executor queue metrics

### Why are the changes needed?

Fix: #1459 #1460 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UTs
@zuston zuston closed this as completed Jan 25, 2024
zuston added a commit to zuston/incubator-uniffle that referenced this issue May 27, 2024
…and support event retry into pending queue (apache#1461)

### What changes were proposed in this pull request?

1. Refactor DefaultFlushEventHandler to unify the logic of handling event
2. Fix incorrect some metrics 
3. Support retry event into pending queue
4. Fix the incorrect inFlushQueueSize
5. Introduce the underlying executor queue metrics

### Why are the changes needed?

Fix: apache#1459 apache#1460 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant