Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] We should force spotless-maven-plugin to use UNIX line endings #1453

Closed
3 tasks done
rickyma opened this issue Jan 15, 2024 · 0 comments
Closed
3 tasks done

[Improvement] We should force spotless-maven-plugin to use UNIX line endings #1453

rickyma opened this issue Jan 15, 2024 · 0 comments

Comments

@rickyma
Copy link
Contributor

rickyma commented Jan 15, 2024 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

When we use the spotless-maven-plugin to format code on the Windows platform, it can cause changes in the file's line endings. We need to force a specific(UNIX: LF) line ending in the pom.xml. This ensures that the final output of line endings is consistent, regardless of the platform used to format the code.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Jan 15, 2024
@rickyma
[apache#1453] improvement: Force to use the UNIX line ending when usi…
edac826 
…ng spotless-maven-plugin
@rickyma rickyma mentioned this issue Jan 15, 2024
Merged
zuston pushed a commit that referenced this issue Jan 16, 2024
@rickyma
[#1453] improvement: Force to use the UNIX line ending when using spo…
e049a27 
…tless-maven-plugin (#1454)

### What changes were proposed in this pull request?

Force to use the UNIX line ending when using spotless-maven-plugin.

### Why are the changes needed?

For [#1453](#1453)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

By running `./mvnw spotless:apply -Pspark3 -Pspark2 -Ptez -Pmr -Phadoop2.8` on Windows.
@zuston zuston closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zuston @rickyma