[FOLLOWUP] Remove unused methods in Storage interface (#431)

### What changes were proposed in this pull request? 1. Remove unused methods in Storage interface ### Why are the changes needed? 1. Remove it to make more clear. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Don't need
apache · Dec 16, 2022 · d897059 · d897059
1 parent 4bd3af6
commit d897059
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 47 deletions.
diff --git a/storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java b/storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java
@@ -81,18 +81,6 @@ public boolean containsWriteHandler(String appId, int shuffleId, int partition)
     return map.containsKey(partitionKey);
   }
 
-  @Override
-  public CreateShuffleWriteHandlerRequest getCreateWriterHandlerRequest(
-      String appId,
-      int shuffleId,
-      int partition) {
-    Map<String, CreateShuffleWriteHandlerRequest> requestMap = requests.get(appId);
-    if (requestMap != null) {
-      return requestMap.get(RssUtils.generatePartitionKey(appId, shuffleId, partition));
-    }
-    return null;
-  }
-
   @Override
   public void removeHandlers(String appId) {
     writerHandlers.remove(appId);

diff --git a/storage/src/main/java/org/apache/uniffle/storage/common/HdfsStorage.java b/storage/src/main/java/org/apache/uniffle/storage/common/HdfsStorage.java
@@ -76,16 +76,6 @@ public boolean unlockShuffleShared(String shuffleKey) {
     return true;
   }
 
-  @Override
-  public boolean lockShuffleExcluded(String shuffleKey) {
-    return true;
-  }
-
-  @Override
-  public boolean unlockShuffleExcluded(String shuffleKey) {
-    return true;
-  }
-
   @Override
   public void updateReadMetrics(StorageReadMetrics metrics) {
     // do nothing

diff --git a/storage/src/main/java/org/apache/uniffle/storage/common/LocalStorage.java b/storage/src/main/java/org/apache/uniffle/storage/common/LocalStorage.java
@@ -121,25 +121,6 @@ public boolean unlockShuffleShared(String shuffleKey) {
     return true;
   }
 
-  @Override
-  public boolean lockShuffleExcluded(String shuffleKey) {
-    ReadWriteLock lock = getLock(shuffleKey);
-    if (lock == null) {
-      return false;
-    }
-    return lock.writeLock().tryLock();
-  }
-
-  @Override
-  public boolean unlockShuffleExcluded(String shuffleKey) {
-    ReadWriteLock lock = getLock(shuffleKey);
-    if (lock == null) {
-      return false;
-    }
-    lock.writeLock().unlock();
-    return true;
-  }
-
   @Override
   public void updateWriteMetrics(StorageWriteMetrics metrics) {
     updateWrite(RssUtils.generateShuffleKey(metrics.getAppId(), metrics.getShuffleId()),

diff --git a/storage/src/main/java/org/apache/uniffle/storage/common/Storage.java b/storage/src/main/java/org/apache/uniffle/storage/common/Storage.java
@@ -33,10 +33,6 @@ public interface Storage {
 
   boolean unlockShuffleShared(String shuffleKey);
 
-  boolean lockShuffleExcluded(String shuffleKey);
-
-  boolean unlockShuffleExcluded(String shuffleKey);
-
   void updateWriteMetrics(StorageWriteMetrics metrics);
 
   void updateReadMetrics(StorageReadMetrics metrics);
@@ -45,8 +41,6 @@ public interface Storage {
 
   ServerReadHandler getOrCreateReadHandler(CreateShuffleReadHandlerRequest request);
 
-  CreateShuffleWriteHandlerRequest getCreateWriterHandlerRequest(String appId, int shuffleId, int partition);
-
   void removeHandlers(String appId);
 
   void createMetadataIfNotExist(String shuffleKey);