kie-issues#2548: Cannot add a new record within an empty Decision Table

[Kusuma04-dev]

closes #2548 Cannot add a new record within an empty decision table

Before fix:
When user added empty decision table without any row , + icon is not visible to add rows.

After fix:
If user added an empty decision table then row is displayed, if user added something in that row then only it is updated otherwise row is just for display purpose and here if user tries to add another row , he can able to add after updating something in the displayed row.

[jomarko]

@Kusuma04-dev Hi, thank you for the PR. I think from now one users will be able to add rows even to a table, that has zero rows/rules in the xml.

However, I would like to share one idea/proposal, that from my point of view would make more clear difference between no data state vs some data state.

Currently we have

0 rows just opened

0 rows transformed to one row

Proposal

0 rows just opened

0 rows transformed to one row

[Kusuma04-dev]

@Kusuma04-dev Hi, thank you for the PR. I think from now one users will be able to add rows even to a table, that has zero rows/rules in the xml.

However, I would like to share one idea/proposal, that from my point of view would make more clear difference between no data state vs some data state.

Currently we have

0 rows just opened

0 rows transformed to one row

Proposal

0 rows just opened

0 rows transformed to one row

Thanks Jozef for the review and the proposal. I agree with you ,with these changes user can distinguish between dummy row and actual row.

[Kusuma04-dev]

@tiagobento , Can you please share your thoughts on this:
Can we do like this as jozef mentioned:

Screen.Recording.2025-02-19.at.6.16.31.PM.mov

[tiagobento]

IDK I think it's weird to have to click on the + sign to add a row that is already there. If we always show at lest one row (even if the DMN XML says the Decision Table has 0 rows), users will be able to use normally...

[Kusuma04-dev]

IDK I think it's weird to have to click on the + sign to add a row that is already there. If we always show at lest one row (even if the DMN XML says the Decision Table has 0 rows), users will be able to use normally...

@tiagobento ,Thanks for your suggestion , Yeah user can use normally ,here 1st row which is displayed is not actual rule , it becomes active only when user added something then they can use normally but if user didn't add anything then clicked on + icon then it will add 1st row(considering no rule present before). Please share your view on this if this is fine or we need to modify anything?

[Kusuma04-dev]

Hi @tiagobento @jomarko , I have made the changes to make it work as normal decisiontable, Please review and suggest if anything is missing.