kie-tools-issues#2641: Upgrade Patternfly to v5 #2853

kumaradityaraj · 2025-01-13T11:11:50Z

Closes #1877
Closes #2641

Upgrade Patternfly from v4 to v5 to the full repository following PatternFly's migration.

guide: https://www.patternfly.org/get-started/upgrade/#patternfly-5

Updated packages
@kie-tools-core/editor
@kie-tools-examples/base64png-editor
@kie-tools-examples/uniforms-patternfly
@kie-tools-examples/webapp
@kie-tools/boxed-expression-component
@kie-tools/dashbuilder-component-table
@kie-tools/dashbuilder-component-uniforms
@kie-tools/dashbuilder-component-victory-charts
@kie-tools/dashbuilder-editor
@kie-tools/dashbuilder-viewer
@kie-tools/dashbuilder-viewer-deployment-webapp
@kie-tools/dev-deployment-dmn-form-webapp
@kie-tools/dmn-editor
@kie-tools/dmn-editor-envelope
@kie-tools/dmn-editor-standalone
@kie-tools/dmn-runner
@kie-tools/form
@kie-tools/form-dmn
@kie-tools/import-java-classes-component
@kie-tools/kie-bc-editors
@kie-tools/online-editor
@kie-tools/pmml-editor
@kie-tools/runtime-tools-components
@kie-tools/runtime-tools-management-console-webapp
@kie-tools/runtime-tools-process-dev-ui-webapp
@kie-tools/runtime-tools-process-enveloped-components
@kie-tools/runtime-tools-shared-enveloped-components
@kie-tools/runtime-tools-shared-webapp-components
@kie-tools/runtime-tools-swf-enveloped-components
@kie-tools/runtime-tools-swf-webapp-components
@kie-tools/runtime-tools-task-console-webapp
@kie-tools/scesim-editor
@kie-tools/serverless-logic-web-tools
@kie-tools/serverless-workflow-combined-editor
@kie-tools/serverless-workflow-dev-ui-webapp
@kie-tools/serverless-workflow-text-editor
@kie-tools/sonataflow-management-console-webapp
@kie-tools/text-editor
@kie-tools/uniforms-patternfly
@kie-tools/unitables
@kie-tools/unitables-dmn
@kie-tools/yard-editor
sonataflow-deployment-webapp

See more: https://docs.google.com/spreadsheets/d/1V1LxLuu4Vv6-V8ncOMKH7vXHog5fQiwcnMw-glLq32k/edit?gid=1948850227#gid=1948850227

…4 to p5

…ration

fix the CustomWorkflowForm errors

…act#10064

…/kie-tools into allpackagesp4top5

jomarko · 2025-01-20T13:52:39Z

14 Folder Toolbar Icons

Please compare group icon size in main:

vs PR:

jomarko · 2025-01-20T13:54:57Z

15 Include model styling

is different on main:

vs in PR:

also the background for included model cards is different on main:

vs pr:

jomarko · 2025-01-20T15:05:39Z

16 Create github gist

Has some unexpected content if we compare main:

with PR:

The same issue we see for github repository when we compare main:

with PR:

jomarko

I will stop my review here. I think I tested quite well 2 of three componenets I was asked:

online-editor ✔️
dmn-editor ✔️
dev-deployment-dmn-form-webapp 🚫

I think I could test also runtime-tools-process-dev-ui-webapp however will do maybe in secound round of review.

dev-deployment-dmn-form-webapp

The problem I have for testing dev-deployment-dmn-form-webapp is I never used it as standalone and locally

I made this build:

KIE_TOOLS_BUILD__buildContainerImages=true pnpm -F @kie-tools/dev-deployment-kogito-quarkus-blank-app-image... build:prod
KIE_TOOLS_BUILD__buildContainerImages=true pnpm -F @kie-tools/dev-deployment-dmn-form-webapp-image... build:prod

Then started:

docker run -p 8080:8080 -e DEV_DEPLOYMENT__UPLOAD_SERVICE_API_KEY=dev docker.io/apache/incubator-kie-sandbox-dev-deployment-kogito-quarkus-blank-app:main
docker run -d -p 8081:8081 -e DEV_DEPLOYMENT_DMN_FORM_WEBAPP_QUARKUS_APP_ORIGIN=http://localhost:8080 docker.io/apache/incubator-kie-sandbox-dev-deployment-dmn-form-webapp:main

And tried to deploy DMN as:

curl -X POST -H "Content-Type: multipart/form-data" -F "myFile=/home/jomarko/kie-tools/examples/process-compact-architecture/src/main/resources/assets.zip" 'http://localhost:8080/upload?apiKey=dev'

However always get some error, I need more guidance how to deploy some dmn on the running images.

[dev-deployment-upload-service] ℹ️  Upload arrived...
[dev-deployment-upload-service] ❌ ERROR: Reading uploaded file failed:
[dev-deployment-upload-service] ❌ ERROR: http: no such file
2025/01/20 15:53:33 http: panic serving 172.17.0.1:50788: runtime error: invalid memory address or nil pointer dereference
goroutine 49 [running]:
net/http.(*conn).serve.func1()
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:1903 +0xbe
panic({0x667c00?, 0x8c0d60?})
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/runtime/panic.go:770 +0x132
main.main.func3({0x727320, 0xc0002ba000}, 0xc0002ac000)
        /home/jomarko/kie-tools/packages/dev-deployment-upload-service/main.go:169 +0x7d5
net/http.HandlerFunc.ServeHTTP(0x8cce50?, {0x727320?, 0xc0002ba000?}, 0x10?)
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2171 +0x29
net/http.(*ServeMux).ServeHTTP(0x40e745?, {0x727320, 0xc0002ba000}, 0xc0002ac000)
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2688 +0x1ad
net/http.serverHandler.ServeHTTP({0x7266a0?}, {0x727320?, 0xc0002ba000?}, 0x6?)
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:3142 +0x8e
net/http.(*conn).serve(0xc000296000, {0x727840, 0xc000200210})
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2044 +0x5e8
created by net/http.(*Server).Serve in goroutine 19
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:3290 +0x4b4
[dev-deployment-upload-service] ⚠️  Upload arrived, but another arrived earlier. Server should be in the process of gracefully shutting down.

Please let me know once the PR is ready for my another review round. Once more, thank you for this huge effort!

fantonangeli · 2025-01-28T11:58:00Z

@jomarko Thanks a lot for your review. Regarding the tests for dev-deployment-dmn-form-webapp, is it enough to test with this command only?
pnpm -F dev-deployment-dmn-form-webapp start
then open:
http://localhost:9008/

I will stop my review here. I think I tested quite well 2 of three componenets I was asked:

* `online-editor` ✔️

* `dmn-editor` ✔️

* `dev-deployment-dmn-form-webapp` 🚫

I think I could test also runtime-tools-process-dev-ui-webapp however will do maybe in secound round of review.

dev-deployment-dmn-form-webapp

The problem I have for testing dev-deployment-dmn-form-webapp is I never used it as standalone and locally

I made this build:

* `KIE_TOOLS_BUILD__buildContainerImages=true pnpm -F @kie-tools/dev-deployment-kogito-quarkus-blank-app-image... build:prod`

* `KIE_TOOLS_BUILD__buildContainerImages=true pnpm -F @kie-tools/dev-deployment-dmn-form-webapp-image... build:prod`

Then started:

* `docker run -p 8080:8080 -e DEV_DEPLOYMENT__UPLOAD_SERVICE_API_KEY=dev docker.io/apache/incubator-kie-sandbox-dev-deployment-kogito-quarkus-blank-app:main`

* `docker run -d -p 8081:8081 -e DEV_DEPLOYMENT_DMN_FORM_WEBAPP_QUARKUS_APP_ORIGIN=http://localhost:8080 docker.io/apache/incubator-kie-sandbox-dev-deployment-dmn-form-webapp:main`

And tried to deploy DMN as:

* `curl -X POST -H "Content-Type: multipart/form-data" -F "myFile=/home/jomarko/kie-tools/examples/process-compact-architecture/src/main/resources/assets.zip" 'http://localhost:8080/upload?apiKey=dev'`

However always get some error, I need more guidance how to deploy some dmn on the running images.

[dev-deployment-upload-service] ℹ️  Upload arrived...
[dev-deployment-upload-service] ❌ ERROR: Reading uploaded file failed:
[dev-deployment-upload-service] ❌ ERROR: http: no such file
2025/01/20 15:53:33 http: panic serving 172.17.0.1:50788: runtime error: invalid memory address or nil pointer dereference
goroutine 49 [running]:
net/http.(*conn).serve.func1()
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:1903 +0xbe
panic({0x667c00?, 0x8c0d60?})
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/runtime/panic.go:770 +0x132
main.main.func3({0x727320, 0xc0002ba000}, 0xc0002ac000)
        /home/jomarko/kie-tools/packages/dev-deployment-upload-service/main.go:169 +0x7d5
net/http.HandlerFunc.ServeHTTP(0x8cce50?, {0x727320?, 0xc0002ba000?}, 0x10?)
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2171 +0x29
net/http.(*ServeMux).ServeHTTP(0x40e745?, {0x727320, 0xc0002ba000}, 0xc0002ac000)
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2688 +0x1ad
net/http.serverHandler.ServeHTTP({0x7266a0?}, {0x727320?, 0xc0002ba000?}, 0x6?)
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:3142 +0x8e
net/http.(*conn).serve(0xc000296000, {0x727840, 0xc000200210})
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2044 +0x5e8
created by net/http.(*Server).Serve in goroutine 19
        /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:3290 +0x4b4
[dev-deployment-upload-service] ⚠️  Upload arrived, but another arrived earlier. Server should be in the process of gracefully shutting down.

Please let me know once the PR is ready for my another review round. Once more, thank you for this huge effort!

fantonangeli

Thanks a lot @kumaradityaraj, I'm leaving some points here and I will continue reviewing this PR

...classes-component/src/components/ImportJavaClasses/ImportJavaClassesWizardFieldListTable.tsx

packages/online-editor/src/accounts/git/ConnectToGitSection.tsx

packages/online-editor/src/accounts/kubernetes/ConnectToLocalKubernetesClusterWizard.tsx

...s/online-editor/src/accounts/openshift/ConnectToDeveloperSandboxForRedHatOpenShiftWizard.tsx

packages/online-editor/src/authProviders/AuthProviderIcon.tsx

packages/pmml-editor/src/editor/components/EditorScorecard/molecules/AttributeEditor.tsx

packages/pmml-editor/src/editor/components/Outputs/organisms/OutputsHandler.tsx

packages/runtime-tools-components/src/common/components/LoadMore/LoadMore.tsx

packages/online-editor/src/importFromUrl/ImportFromUrlHomePageCard.tsx

packages/dashbuilder-component-victory-charts/src/charts/DonutChart.tsx

packages/scesim-editor/src/TestScenarioEditor.tsx

packages/patternfly-base/index.js

packages/sonataflow-deployment-webapp/src/pages/BasePage.tsx

packages/sonataflow-deployment-webapp/src/runtimeTools/pages/RuntimeToolsWorkflowInstances.tsx

packages/sonataflow-management-console-webapp/src/components/pages/BasePage.tsx

...t/java/org/kie/workbench/common/dmn/showcase/client/selenium/locator/EditorXPathLocator.java

packages/yard-editor/dev-webapp/EmptyState.tsx

apache#2853 (comment)

fantonangeli

Thank a lot @kumaradityaraj.
Here are some more suggestions, please let me know if you need some clarification.

fantonangeli · 2025-02-17T11:18:30Z

...ges/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx

@@ -467,7 +468,9 @@ function JavaFunctionExpressionLabelCell(props: React.PropsWithChildren<BeeTable
            headerContent={label + " example"}
            bodyContent={getParameterLabelHelp}
          >
-            <HelpIcon size="sm" className="java-function-parameter-help-icon" />
+            <Icon size="sm" style={{ marginLeft: "10px", marginTop: "5px" }}>


Can we modify the CSS class already created instead of using the style property?
https://github.com/kumaradityaraj/kie-tools/blob/5b709227e7f140157157c3e3a45ceaf6f258af65/packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.css#L49

packages/online-editor/src/accounts/AccountsIcon.tsx

fantonangeli · 2025-02-17T14:57:32Z

packages/online-editor/src/authProviders/AuthProviderIcon.tsx

@@ -27,36 +26,26 @@ import QuestionIcon from "@patternfly/react-icons/dist/js/icons/question-icon";
 import UsersIcon from "@patternfly/react-icons/dist/js/icons/users-icon";
 import { AuthProvider } from "./AuthProvidersApi";

-export function AuthProviderIcon(props: {
-  authProvider: AuthProvider | undefined;
-  size: IconSize | keyof typeof IconSize;


Before AuthProviderIcon was accepting a props for the size here.
We can use that property like it was before and pass the size to the Icon tag inside AuthProviderIcon so who call it can decide the size.

fantonangeli · 2025-02-17T14:58:30Z

packages/online-editor/src/authProviders/AuthProviderIcon.tsx

-    return <UsersIcon size={props.size} />;
-  }
-
-  if (props.authProvider.iconPath) {


Following my previous comment we can bring back this portion of code

packages/sonataflow-deployment-webapp/src/pages/BasePage.tsx

kumaradityaraj and others added 30 commits October 7, 2024 13:14

Made changes through codemod

347112a

Upgrading version

cc17553

Fix fonts resources for double PF versions

eaeb408

new pf5 package for runtime tools components

9d1e523

runtime-tools-components-pf5 fixes

e864011

Last commit before making a new branch from this - All package from p…

c0f76e4

…4 to p5

pf has been updated in all packages

ae1d043

Codemod changes executed

c1f0c3d

Codemod executed in runtime-tools-components

20b62ad

updated uniform patternfly

248240e

Testing - sonataflowwebapp and sonataflowmanagement console first ite…

8ce2189

…ration

Components refining runtimet tool components

abb042e

Errors resolved in various components

abd11f9

Executed codemod again to check erors

013678c

Reverted some changes to packages/uniforms-patternfly/package.json to

2e79015

fix the CustomWorkflowForm errors

Resolved errors shown in building packages

c87ccf2

Updated classes of all styles.css

cf9b5a9

changed bg color of nav menu

37ae2dd

made changes for building the packages

c48d6ff

removed text from nav bar

6e079ab

Fix dep mismatch

b02a563

Update @patternfly/react-charts to fix issue patternfly/patternfly-re…

2529ddd

…act#10064

Merge branch 'allpackagesp4top5' of https://github.com/kumaradityaraj…

75e2e36

…/kie-tools into allpackagesp4top5

pmml-editor pf5 upgrades

31321d8

resolved toogle button of dark mode

072270a

notification issue resolved

474e6ae

notification

afbcad4

resolved errors in boxed-expression

bc10343

fixed the alignment of text in sonataflow-deployment-webapp

55b8649

reverting back uniform patternfly

35497fd

jomarko reviewed Jan 20, 2025

View reviewed changes

kumaradityaraj added 5 commits January 23, 2025 13:51

Resolving issue 01 Home Screen

5599dd7

Resolving issue 02 Connected Accounts

e332421

Resolving issue 02 Connected Accounts

0ea68ac

Resolving issue 03 Extended services settings

2cc9cb3

Resolving issue 03 Extended services settings

5dbe357

kumaradityaraj added 3 commits January 29, 2025 14:03

Resolving issue 06 New DMN Editor button

12f5d39

Resolving issue 07 New File Authentication

b936239

Resolving issue 16 Create Github Gist

52d1484

fantonangeli requested changes Feb 4, 2025

View reviewed changes

kumaradityaraj added 3 commits February 5, 2025 13:14

Resolving issue 16 Create github gist

7479938

Making suggested changes

bb7bfa1

Resolving issue 15 Include model styling

9f0a40d

fantonangeli requested changes Feb 6, 2025

View reviewed changes

kumaradityaraj and others added 11 commits February 10, 2025 13:54

Removing theme variant from victory charts

4715395

Removing theme variant from victory charts

120fa9b

Resolving suggested changes

010d435

Resolving issue 8 & 9

a2178ff

Resolving issue 10

8d159ea

Resolving issue 10

c606c92

Fixes issue apache#5

9cb66c0

apache#2853 (comment)

Resolving issue 12 Java function parameters help icon

6aa826c

Resolving issue 14 Folder Toolbar Icons size

a87bc50

removed all commented helper text

cef6803

04 No Dev Deployments

5b70922

fantonangeli requested changes Feb 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kie-tools-issues#2641: Upgrade Patternfly to v5 #2853

kie-tools-issues#2641: Upgrade Patternfly to v5 #2853

kumaradityaraj commented Jan 13, 2025 •

edited by tiagobento

Loading

jomarko commented Jan 20, 2025

jomarko commented Jan 20, 2025 •

edited

Loading

jomarko commented Jan 20, 2025 •

edited

Loading

jomarko left a comment

fantonangeli commented Jan 28, 2025

dev-deployment-dmn-form-webapp

fantonangeli left a comment

fantonangeli left a comment

fantonangeli Feb 17, 2025

fantonangeli Feb 17, 2025

fantonangeli Feb 17, 2025

kie-tools-issues#2641: Upgrade Patternfly to v5 #2853

Are you sure you want to change the base?

kie-tools-issues#2641: Upgrade Patternfly to v5 #2853

Conversation

kumaradityaraj commented Jan 13, 2025 • edited by tiagobento Loading

jomarko commented Jan 20, 2025

14 Folder Toolbar Icons

jomarko commented Jan 20, 2025 • edited Loading

15 Include model styling

jomarko commented Jan 20, 2025 • edited Loading

16 Create github gist

jomarko left a comment

Choose a reason for hiding this comment

dev-deployment-dmn-form-webapp

fantonangeli commented Jan 28, 2025

dev-deployment-dmn-form-webapp

fantonangeli left a comment

Choose a reason for hiding this comment

fantonangeli left a comment

Choose a reason for hiding this comment

fantonangeli Feb 17, 2025

Choose a reason for hiding this comment

fantonangeli Feb 17, 2025

Choose a reason for hiding this comment

fantonangeli Feb 17, 2025

Choose a reason for hiding this comment

kumaradityaraj commented Jan 13, 2025 •

edited by tiagobento

Loading

jomarko commented Jan 20, 2025 •

edited

Loading

jomarko commented Jan 20, 2025 •

edited

Loading