kie-issues#1506: Use per-package local Maven repositories for dependency declaration correctness on kie-tools
#2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kie-tools
porcelli
approved these changes
Oct 2, 2024
Rename Fix build reproducibility v2 Oops Fix DashBuilder configuration of maven-deploy-plugin Oops Fix maven-m2-repo-via-http-image configuration . Fix config removing mvn.tail Maybe fix build Rename method Oops Merge maven-config-setup-helper with maven-base Oops Oops env and more stuff Oops. Lockfile Force not skipping local deploy Fix Hm No transfer progres Rename versions env Reverting root files IntelliJ project configuration .
6aea896 to
b5ea429
Compare
c973e4d to
4f0f043
Compare
4f0f043 to
ae51603
Compare
pefernan
reviewed
Oct 7, 2024
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
I think this shouldn't be added right?
There was a problem hiding this comment.
It should. *.iml files are what allow us to have pre-configured default for modules of _intellij-project.
pefernan
approved these changes
Oct 7, 2024
kie-toolskie-tools
thiagoelg
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Awesome job! 🎉
This solves most of the issues we had when building Java packages on kie-tools. Thanks @tiagobento!
yesamer
reviewed
Oct 8, 2024
yesamer
reviewed
Oct 9, 2024
| <remote-repository> | ||
| <option name="id" value="jdt.ls.p2" /> | ||
| <option name="name" value="jdt.ls.p2" /> | ||
| <option name="url" value="https://download.eclipse.org/jdtls/milestones/1.30.1/repository/" /> |
There was a problem hiding this comment.
@tiagobento This repo is strictly related to the current jdt.ls version used in our code. Said so, I would add a comment here and in the vscode-java-code-completion-extension-plugin/pom.xml to warn the user to update the repo when the version is updated.
yesamer
reviewed
Oct 9, 2024
| <version.maven.jar.plugin>3.4.1</version.maven.jar.plugin> | ||
| <version.maven.remote.resources.plugin>3.2.0</version.maven.remote.resources.plugin> | ||
| <version.maven.clean.plugin>3.4.0</version.maven.clean.plugin> | ||
| <version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin> |
There was a problem hiding this comment.
As we discussed in private, as a future improvement I would discuss better centralizing the maven plugin management, declaring them in the maven base pom and inheriting them from the apache pom @tiagobento @pefernan
yesamer
approved these changes
Oct 9, 2024
fantonangeli
added a commit
to fantonangeli/kie-tools
that referenced
this pull request
Oct 25, 2024
rgdoliveira
pushed a commit
to kiegroup/kie-tools
that referenced
this pull request
Oct 25, 2024
…changes (#57) * Apply updates from apache#2635 * Updates from apache#2455 * Updates from apache#2376 * Fixed wrong value for SONATAFLOW_MANAGEMENT_CONSOLE_WEBAPP__sonataflowEnvMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#1506
This PR introduces a new way of working with Maven on
kie-tools. It takes advantage of themaven.repo.local.tailconfiguration option to allow not installing all packages tomaven.repo.localand risk depending on undeclared packages.This new structure depends on quarkusio/quarkus#43352, so it can only be merged oncekie-toolsis using a version of Quarkus that contains this PR.There are a lot of things to be written about this topic, and I'll get to it once we're closer to being able to merge this.I made the ""per-package dist"" way of wiring Maven-based packages together be disabled for now, so we can proceed merging this PR and I'll make it the default once quarkusio/quarkus#43352 is available on Quarkus.
In this PR:
_intellij-projectto hold files that allow importingkie-toolson IntelliJ as a single project.envs. We should reserve the namebuildEnvfor the tool not the values.maven-config-setup-helperintomaven-base, Makingmaven-basethe only requirement for Maven-based packages.-ntpwhere possible to save space on logs.include-1st-party-dependenciesto allow for runningmvnduring bootstrap, when dependencies might not have been built yet.mvnwinstallation tomaven-base, instead of it being a script on package.json. Although I think we could get rid of this entirely.m2-repo-via-http-imageondev-deployment-kogito-quarkus-blank-app-image/package.jsonm2-repo-via-http:container:prepare-m2-repo-volumescripts on packages depending onmaven-m2-repo-via-http-imageto support multiple local Maven repositories, using hard links.DEV_DEPLOYMENT_KOGITO_QUARKUS_BLANK_APP_IMAGE__mavenM2RepoViaHttpImageenv var.kn-plugin-workflowtests to properly wire local test projects with-Dmaven.repo.local.tail.$(build-env quarkusPlatform.version)to$(build-env versions.quarkus)$(build-env kogitoRuntime.version)to$(build-env versions.kogito)kie-toolsmonorepo.Comments and questions are welcome! :)
P.S.: It's expected that a few tests will break onkn-plugin-workflowbecause we're using Quarkus 3.8.6, which doesn't contain the PR I mentioned above.