[Incubator-kie-issues-1790] Enhancing business calendar flexibility #3850
+118
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitgabrio
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Hi @Abhitocode
Please, remove the new template and modify the CompilationUnit of the original one programmatically, if needed (i.e. in case of custom class)
All kogito is based on code-generation, and we can't manage to have different templates (or even couple of them) whenever the body of a method has to be modified.
We use JavaParser as standard library, and there are multiple CodegenUtils classes in our codebase.
demonstrate a lot of different use cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow customers extend the default BusinessCalendar functionality we should allow them to provide their custom calendar implementation (a java class implementing the BusinessCalendar.java interface) and configure the application to help wiring it in the workflow engine.
closes: apache/incubator-kie-issues#1790