Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues 1788] Updating to Keycloak 26.1.0 #3837

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

LightGuard
Copy link
Contributor

Fixes apache/incubator-kie-issues#1788.

Dashbuilder Appformer also uses keycloak, but I think this takes care of it as well. We'll need to do a full build to make sure everything is good.

Should fix CVE-2024-9666 and CVE-2024-7318

This also aligns with Quarkus 3.15.3

Signed-off-by: Jason Porter <lightguard.jp@gmail.com>
@yesamer
Copy link
Contributor

yesamer commented Jan 30, 2025

Dashbuilder Appformer also uses keycloak, but I think this takes care of it as well. We'll need to do a full build to make sure everything is good.

Not sure about that

@baldimir
Copy link
Contributor

baldimir commented Feb 4, 2025

I see this as green. Are there any other checks to be made, please? Or can we merge?

@LightGuard
Copy link
Contributor Author

I believe we're good to merge.

@LightGuard
Copy link
Contributor Author

I've found some other places where we pull in Keycloak transitively in the data-index-persistence addon. It includes quarkus-oidc artifacts, which in turn pull in Keycloak. The biggest problem is that there is no version using a more recent version of keycloak :( I have my doubts of getting it fixed upstream in the 3.15 branch, I could try though.

Just looked, the more recent versions have changed the pom, so that probably won't work.

Do we exclude keycloak in that dependency and get our own version?

@baldimir
Copy link
Contributor

baldimir commented Feb 5, 2025

@LightGuard thanks for checking. I think we could just align with what is in Quarkus now and I guess there will be another Quarkus bump soon as as far as I know there is a very recent new LTS release (or soon will be a new LTS release released).

@LightGuard
Copy link
Contributor Author

Okay, then we're good with this change for now.

@LightGuard
Copy link
Contributor Author

I believe we're good to merge

@baldimir baldimir merged commit 71310a4 into apache:main Feb 18, 2025
7 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CVE] CVE-2024-9666 CVE-2024-7318 Upgrade keycloak
3 participants