[NO-ISSUE][DEP UPDATE] Updating logback to 1.5.16 #3836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing the version used elsewhere. Signed-off-by: Jason Porter <lightguard.jp@gmail.com>
This was referenced Jan 29, 2025
gitgabrio
reviewed
Jan 30, 2025
| @@ -99,6 +99,10 @@ | |||
| <artifactId>kogito-drools</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
HI @LightGuard
This is strange, with regard of the ticket: why is this needed ?
|
Hi @LightGuard |
Removing dependency I think was a C&P error.
Simplifying the diff
Simplify diff take two
LightGuard
commented
Feb 19, 2025
Comment on lines
104
to
105
| </project> No newline at end of file | ||
| </project> |
There was a problem hiding this comment.
I have no idea why it is saying that is changing. Line endings maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for apache/incubator-kie-issues#1787. We're updating SpringBoot, which is using LogBack 1.5.16. It makes sense to keep the versions the same everywhere.
See also:
apache/incubator-kie-tools#2884
apache/incubator-kie-drools#6236